Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy browsers Frame Breaking js code usage and deprecate it #11679

Closed
wants to merge 7 commits into from
Closed

Remove legacy browsers Frame Breaking js code usage and deprecate it #11679

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e515811
remove legacy frame breaking js code
andrepereiradasilva Aug 20, 2016
bc1f3d3
add to the view file
andrepereiradasilva Aug 20, 2016
35b81de
remove behavior.noframes from template
andrepereiradasilva Aug 20, 2016
5b6126c
Remove behavior.noframes from hathor template
andrepereiradasilva Aug 20, 2016
2c9ba8d
restore noframes behaviour and deprecate it on 4.0
andrepereiradasilva Aug 20, 2016
7cea868
remove extra space
andrepereiradasilva Aug 20, 2016
b417a54
missing tab
andrepereiradasilva Aug 20, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 0 additions & 22 deletions libraries/cms/html/behavior.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,28 +800,6 @@ public static function noframes()
return;
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andrepereiradasilva Can you also put depreciation tag on this function?

// Include core
static::core();

// Include jQuery
JHtml::_('jquery.framework');

$js = 'jQuery(function () {
if (top == self) {
document.documentElement.style.display = "block";
}
else
{
top.location = self.location;
}

// Firefox fix
jQuery("input[autofocus]").focus();
})';
$document = JFactory::getDocument();
$document->addStyleDeclaration('html { display:none }');
$document->addScriptDeclaration($js);

JFactory::getApplication()->setHeader('X-Frame-Options', 'SAMEORIGIN');

static::$loaded[__METHOD__] = true;
Expand Down