Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move travis phpunit test preparations into a bash script #11579

Merged
merged 4 commits into from
Aug 13, 2016

Conversation

yvesh
Copy link
Member

@yvesh yvesh commented Aug 13, 2016

Pull Request for #11420.

Summary of Changes

As asked by @rdeutz in #11420 phpunit tests should not be executed when running the javascript tests. In order to achieve that we need to clean up the .travis.yml and move the tests setup to a separate bash script.

This also has the advantage that the formatting and execution workflow can be improved over the one liners we have because of travis now. (Not done with this PR)

Testing Instructions

Review and check the travis log

Documentation Changes Required

None

@rdeutz
Copy link
Contributor

rdeutz commented Aug 13, 2016

I have tested this item ✅ successfully on 23e6e6b

Works as expected


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.

@andrepereiradasilva
Copy link
Contributor

I have tested this item ✅ successfully on 23e6e6b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.

@brianteeman
Copy link
Contributor

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 13, 2016
@brianteeman brianteeman added this to the Joomla 3.6.3 milestone Aug 13, 2016
@jeckodevelopment
Copy link
Member

I have tested this item ✅ successfully on 23e6e6b


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579.

@wilsonge wilsonge merged commit 8498c18 into joomla:staging Aug 13, 2016
@brianteeman brianteeman removed the RTC This Pull Request is Ready To Commit label Aug 13, 2016
@mbabker
Copy link
Contributor

mbabker commented Aug 14, 2016

A little late to the party but can someone move the shell script to the build/travis directory? It's only usable in the Travis environment so it's better to have it there versus in the tests directory. Either that or rename the file to make it perfectly clear it's a Travis environment configuration script.

@rdeutz
Copy link
Contributor

rdeutz commented Aug 14, 2016

Makes sense I will make a PR to move the file

ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
* Moved travis unit tests preparations to a shell script

* Moved travis unit tests preparations to a shell script

* Commented script

* Updated script section
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
* Moved travis unit tests preparations to a shell script

* Moved travis unit tests preparations to a shell script

* Commented script

* Updated script section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants