-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move travis phpunit test preparations into a bash script #11579
Conversation
I have tested this item ✅ successfully on 23e6e6b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579. |
I have tested this item ✅ successfully on 23e6e6b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579. |
I have tested this item ✅ successfully on 23e6e6b This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11579. |
A little late to the party but can someone move the shell script to the |
Makes sense I will make a PR to move the file |
* Moved travis unit tests preparations to a shell script * Moved travis unit tests preparations to a shell script * Commented script * Updated script section
* Moved travis unit tests preparations to a shell script * Moved travis unit tests preparations to a shell script * Commented script * Updated script section
Pull Request for #11420.
Summary of Changes
As asked by @rdeutz in #11420 phpunit tests should not be executed when running the javascript tests. In order to achieve that we need to clean up the .travis.yml and move the tests setup to a separate bash script.
This also has the advantage that the formatting and execution workflow can be improved over the one liners we have because of travis now. (Not done with this PR)
Testing Instructions
Review and check the travis log
Documentation Changes Required
None