Update .travis.yml #11576
Update .travis.yml #11576
Conversation
Load memcachE extension instead memcacheD
|
I'd have to look again but IIRC Memcache isn't something available by On Friday, August 12, 2016, Tomasz Narloch [email protected] wrote:
|
| @@ -68,7 +68,7 @@ before_script: | |||
| # Set up Apache | |||
| # - ./build/travis/php-apache.sh | |||
| # Enable additional PHP extensions | |||
| - if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi | |||
| - if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcache.ini; fi | |||
There was a problem hiding this comment.
Before that PR:
- if I want to install memcachE in travis env why does travis load php memcacheD extension? ???
- MEMCACHE storage is not tested at all in all php version (except hhvm), but should be tested at least in php 5.6
After that PR: If I want travis to test memcachE then travis loads php memcache.ini
- MEMCACHE start be tested and find that PR Massive review and cleanup of JCache #9622 should not be merged because travis failed on that changes.
There was a problem hiding this comment.
That PR changed nothing with the Travis test environment, let's not blame
it on anything right now.
If it did indeed cause Memcache to be fatally unusable (it doesn't sound
like that's the case though), pointing out the specific change would be
helpful.
I honestly think we've just got a case of a typo in the test matrix and
needing to validate the config values for Memcahe to work correctly.
On Saturday, August 13, 2016, Tomasz Narloch [email protected]
wrote:
In .travis.yml
#11576 (comment):@@ -68,7 +68,7 @@ before_script:
Set up Apache
- ./build/travis/php-apache.sh
Enable additional PHP extensions
- if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcached.ini; fi
- if [[ $INSTALL_MEMCACHE == "yes" ]]; then phpenv config-add build/travis/phpenv/memcache.ini; fi
Before PR:
- if I want to install memcachE why does travis load memcacheD? ???
- MEMCACHE storage is not tested at all in all php version (except
hhvm), but should be tested at least in php 5.6After PR: If I want to test memcachE then travis loads memcache.ini
- MEMCACHE start be tested and find that PR Massive review and cleanup of JCache #9622
Massive review and cleanup of JCache #9622 should not be merged
because travis failed on that changes.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/joomla/joomla-cms/pull/11576/files/4937f7cd8d381c37dc9d8bb1899f05d7a1f0b605#r74691928,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAWfobfD_SkKHZzr5JHNivRZ-BUb6hcAks5qfisHgaJpZM4Jjg4Y
.
memcache should available on travis CI for PHP versions up to 5.6 by default https://blog.travis-ci.com/2013-03-08-preinstalled-php-extensions/ I agree that there is a typo in the build matrix, of course now we need to fix the issues in memcache... |
…sion Fix typo. This is related to joomla#11576. IMHO this PR should be applied after PR joomla#11565 will be merged.
|
This PR is outdated. Go to #11659. |
Summary of Changes
Load memcachE extension instead memcacheD if memcachE required.
Testing Instructions
???