system/sef plugin background image parser regexp bug

[brianteeman]

Pull Request for Issue #7267 .

Bug

The problem is that using images in the style attributes for background images and the image urls with a full url:

<div style="background-image: url(&#039;http://test.org/test.png&#039;)"></div>

The regexp is in plugins/system/sef/sef.php which used to find image urls in style attributes to fix them to the current site's relative path:

Test:

<div style="background-image: url(&#039;http://test.org/test.png&#039;)"></div>

Result:

<div style="background-image: url("/my/site/path/&#039;http://test.org/test.png&#039;")"></div>

Desired result: - (Regexp do not match this url.)

<div style="background-image: url(&#039;http://test.org/test.png&#039;)"></div>

[andrepereiradasilva]

brian isn't this the same as #11266 ?

[brianteeman]

No its different as this addresses the use case of &#39 but probably should be added to that PR by @ggppdk and then I can close this

[ggppdk]

Actually we need to exclude:
Single quotes

'    '

Double quotes

"   "

Also my initial suggestion does not work right for all cases

Thus yes this should be excluded

<div style="background-image: url(&#039;http://test.org/test.png&#039;)"></div>

But this should be included

<div style="background-image: url(&#039;images/test.png&#039;)"></div>

The check needs to go earilier at regexp at quotes checking:

[\'\"]

should be

([\'\"]|\&\#0?34;|\&\#0?39;)

@brianteeman
I ll test that it works for desired cases and commit to other PR ?

• also another reason for adding this to the other PR, is that the other PR will output the original type of quotes:

'
"
'
'
"
"

[brianteeman]

When you update your PR I will close this - thanks

On 3 August 2016 at 14:46, Georgios Papadakis [email protected]
wrote:

Actually we need to exclude:
Single quotes

' '

Double quotes

" "

Also my initial suggestion does not work right for all cases

Thus yes this should be excluded

But this should be included

The check needs to go earilier at regexp at quotes checking:

['"]

should be

(['"]|&#0?34;|&#0?39;)

@brianteeman https://github.com/brianteeman
I ll test that it works for desired cases and commit to other PR ?

• also another reason for adding this to the other PR, is that the
  other PR will output the original type of quotes:

'
"
'
'
"
"

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#11412 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cZHSY1GMSQUyz34VzgRBCc4QkxMks5qcJu6gaJpZM4JboBn
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

[ggppdk]

@brianteeman

i have updated the other PR to add cases like:

style='background-image:url("...");'
style="background-image:url('...');"
style='background-image:url("...");'
style="background-image:url('...');"

So you can close this PR, i tried to make some easier and more complete testing instructions too

[brianteeman]

Thanks very much - closing in favour of #11266