Fix#11155 Two finder module make invalid HTML for W3C

[ghost]

Pull Request for Issue #11155 .

Summary of Changes

Added postfix for attributes id and for in HTML and JS.

Testing Instructions

See #11155 please.

Test also with setting autosuggest if there are any conflicts with jquery.autocomplete.min.js

Test also with activated cache in module. I'm not sure...

[ggppdk]

Nice work but

why use a random number ?
in other cases we use module->id to make the HTML tag IDs unique,

• using a random number makes impossible to locate the module by id via CSS or JS

[ghost]

@ggppdk
Yes, you're right. I was a bit tired ;-)

[brianteeman]

Doesnt the same change have to be made to mod_search?

[dgrammatiko]

Line 15 also MUST change to JHtml::_('formbehavior.chosen', '.advancedSelect'); because if you call chosen without any selector the it will be applied to all select elements in the page and thus will break any functionality for 3PD extension that have javascript that manipulates any selects.

[ghost]

No. Without selector the default one is .advancedSelect.
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/html/formbehavior.php#L40

[ghost]

@brianteeman

Doesnt the same change have to be made to mod_search?

See new PR #11229
But we have a conflict in template Beez3 then.

[ggppdk]

I have tested this item ✅ successfully on 65e5538

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11168.}

[truptikagathara]

I have tested this item ✅ successfully on 65e5538

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11168.}

[brianteeman]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11168.}