Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JDocumentRendererHtmlHead] only add the type attribute in the new script options if it's not an html5 page #10632

Closed

Conversation

andrepereiradasilva
Copy link
Contributor

@andrepereiradasilva andrepereiradasilva commented May 26, 2016

Summary of Changes

#9843 removed all the type attributes in html5 pages if they are the default html5 types for js/css.

But #3072 added a new script options render to JDocument renderer for HTML head.

For consistency, this simple PR does the same for the new script options.

Testing Instructions

Very simple PR. Code review.
Or ... you can follow the same test instructions as #9843 and #3072.

…l5 template (like doen for the rest of js/css already)
@wojsmol
Copy link
Contributor

wojsmol commented May 26, 2016

I have tested this item ✅ successfully on b4d0025


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632.

@grhcj
Copy link

grhcj commented Jun 27, 2016

I have tested this item ✅ successfully on b4d0025

Code review and comparison with #3072.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632.

@brianteeman
Copy link
Contributor

rtc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10632.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jun 27, 2016
@roland-d roland-d added this to the Joomla 3.7.0 milestone Jul 16, 2016
@wilsonge
Copy link
Contributor

wilsonge commented Sep 3, 2016

This has been rewritten in 3.7.x with #11671 - so this is no longer relevent I'm afraid. Closing

@wilsonge wilsonge closed this Sep 3, 2016
@wilsonge wilsonge removed this from the Joomla 3.7.0 milestone Sep 3, 2016
@joomla-cms-bot joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants