-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mod_login] Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8') #10406
Conversation
I have tested this item ✅ successfully on 8a3e663 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
1 similar comment
I have tested this item ✅ successfully on 8a3e663 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
} endif; ?> | ||
<?php if ($params->get('name') == 0) : ?> | ||
<?php echo JText::sprintf('MOD_LOGIN_HINAME', htmlspecialchars($user->get('name')), ENT_COMPAT, 'UTF-8'); ?> | ||
<?php else : ?> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Parentheses is in the wrong place.
@brianteeman same thing. Please remove the RTC. |
@zero-24 @andrepereiradasilva Please see zero-24#13 |
This PR has received new commits. CC: @brianteeman, @BurtNL This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
seems fine to me now. |
Back to Pending. Thanks @wojsmol and @andrepereiradasilva This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
This PR has received new commits. CC: @brianteeman, @BurtNL This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
I have tested this item ✅ successfully on fd6e877 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
I have tested this item ✅ successfully on fd6e877 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/10406. |
Thanks everybody |
Pull Request for Issue #10399 .
Summary of Changes
Always use htmlspecialchars($str, ENT_COMPAT, 'UTF-8')
Testing Instructions