redis is valid for hhvm #10384
Merged
redis is valid for hhvm #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes unit test failure
```php
JCacheStorageTest::testGetInstance with data set "defaultredis" ('redis', array(null, 'en-GB', true, null, 1462454997), 'JCacheStorageRedis')
Undefined variable: connection
/tests/unit/core/helper/helper.php:52
/libraries/joomla/cache/storage/redis.php:105
/libraries/joomla/cache/storage/redis.php:48
/libraries/joomla/cache/storage.php:169
/tests/unit/suites/libraries/joomla/cache/JCacheStorageTest.php:238
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for one of the failures in Issue #10220 .
Summary of Changes
removes redis exclusion from hhvm testing
fixes unit test failure
Testing Instructions
merge on review
Since hhvm is failing with memory I have a patch where I filtered for just the cache tests
before patch error (showing just redis cache test failures)
https://travis-ci.org/photodude/joomla-cms/jobs/127977188
after patch the redis error is gone (showing all cache tests, redis is no longer in the list)
https://travis-ci.org/photodude/joomla-cms/jobs/129048590