Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] mod_article_news readmore missing string #31117

Closed
brianteeman opened this issue Oct 16, 2020 · 2 comments
Closed

[4.0] mod_article_news readmore missing string #31117

brianteeman opened this issue Oct 16, 2020 · 2 comments

Comments

@brianteeman
Copy link
Contributor

brianteeman commented Oct 16, 2020

Steps to reproduce the issue

create a module of type mod_article_news readmore
and make sure that you set it to show readmore
publish the module on a page that is NOT com_content

Expected result

readmore links displayed

Actual result

string is not translated
image

Additional comments

This was caused by my PR #30780 which switched to make sure the layout was used. However the layout requires the com_content language file.

The switch to use the layout was correct. So we have to either

  1. change the strings to global strings
    or
  2. always load the com_content language string with the module
    or
  3. add the strings to the module language file
COM_CONTENT_READ_MORE="Read more ..."
COM_CONTENT_READ_MORE_TITLE="Read more: %s"
COM_CONTENT_REGISTER_TO_READ_MORE="Register to read more ..."
@richard67
Copy link
Member

I vote for global strings.

brianteeman added a commit to brianteeman/joomla-cms that referenced this issue Oct 17, 2020
PR for joomla#31117

### Steps to reproduce the issue
create a module of type mod_article_news readmore
and make sure that you set it to show readmore
publish the module on a page that is NOT com_content

### Expected result
readmore links displayed

### Actual result
string is not translated
@brianteeman
Copy link
Contributor Author

See #31123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants