Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.0] Test upgrade path from Joomla 3 to Joomla 4 on Postgres #25467

Closed
wilsonge opened this issue Jul 7, 2019 · 11 comments
Closed

[4.0] Test upgrade path from Joomla 3 to Joomla 4 on Postgres #25467

wilsonge opened this issue Jul 7, 2019 · 11 comments

Comments

@wilsonge
Copy link
Contributor

wilsonge commented Jul 7, 2019

@alikon @richard67 (or anyone else running postgres) can you please test the following:

  1. Install a copy of Joomla 3.x (I was using 3.9.9 RC) on postgres
  2. Use the upload file functionality with the latest nightly (https://developer.joomla.org/nightly-builds.html)
  3. Check if Joomla upgrades successfully

Caveats:

  • On the intermediate authentication pages you'll get template not found warnings (and the styling is not optimal)
  • But once you get the Update finished page then you need to navigate to any other page and then proceed without any issues.

However I expect the upgrade to actually work in functionality

@richard67
Copy link
Member

Ok, will do that tomorrow evening after work, German time.

@ghost ghost added the J4 Issue label Jul 8, 2019
@alikon
Copy link
Contributor

alikon commented Jul 8, 2019

let me invite @twister65 to this postgresql party

@twister65
Copy link
Contributor

I have this error during the upgrade:
JoomlaPG_upgrade
It means that the timestamp of "checked_out_time" in

('atum', 'template', 'atum', '', 1, 1, 1, 0, '{}', '{}', '', '', 0, '0000-00-00 00:00:00', 0, 0),
('cassiopeia', 'template', 'cassiopeia', '', 0, 1, 1, 0, '{}', '{}', '', '', 0, '0000-00-00 00:00:00', 0, 0);

is not correct, it should be:
'1970-01-01 00:00:00' instead of '0000-00-00 00:00:00'

twister65 added a commit to twister65/joomla-cms that referenced this issue Jul 8, 2019
@twister65
Copy link
Contributor

Error
The template for this display is not available.

I've got the same error with MySQL.

@twister65
Copy link
Contributor

After building a new update package, I have this error:
home_error
It means that the home expression should be smallint and not text.

('atum', 1, (CASE WHEN (SELECT count FROM (SELECT count("id") AS count FROM "#__template_styles" WHERE home = '1' AND client_id = 1 AND "template" IN ('isis', 'hathor')) as c) = 0 THEN '0' ELSE '1' END), 'atum - Default', '{}'),
('cassiopeia', 0, (CASE WHEN (SELECT count FROM (SELECT count("id") AS count FROM "#__template_styles" WHERE home = '1' AND client_id = 0 AND "template" IN ('protostar', 'beez3')) as c) = 0 THEN '0' ELSE '1' END), 'cassiopeia - Default', '{}');

twister65 added a commit to twister65/joomla-cms that referenced this issue Jul 8, 2019
@alikon
Copy link
Contributor

alikon commented Jul 8, 2019

@twister65 can you add your findings to #25461 if you want
https://github.com/joomla/joomla-cms/pull/25461/files#diff-18dfb1b9c26a65fe27454cb3d7081eb0
branch is open even if is most related to mysql

@twister65
Copy link
Contributor

@alikon , I can't push in your branch:

Unable to push
remote: Permission to alikon/joomla-cms.git denied to twister65.
fatal: unable to access 'https://github.com/alikon/joomla-cms.git/': The requested URL returned error: 403

Should I make a PR ?

@richard67
Copy link
Member

@twister65 Would be good if you could make a PR. I don't think it was a good idea by @alikon to add that to his PR, because his PR is focused on mysql and we should not mix things.

@alikon
Copy link
Contributor

alikon commented Jul 8, 2019

not a problem do as it is best for you

@richard67
Copy link
Member

@wilsonge With twister's PR #25477 applied to the update package from last nightly build, the SQL errors disappear, and the behavior becomes like you described above, i.e. there are "template not found" warnings, but they disappear when update is finished and you are navigating through backend. So that PR makes the update finish without crash.

But there remain other issues to be handled. The first thing I saw is that com_search has been removed, but the menu entry in the left side admin menu in backend is still there. I don't dare to think about what will happen when updating a site with a search module in frontend. Do you have any plan for that already?

@ghost
Copy link

ghost commented Jul 9, 2019

Closed as having Pull Request #25477

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants