Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[com_fields] 0 Invalid controller: name='article', format='' #13267

Closed
waader opened this issue Dec 18, 2016 · 10 comments
Closed

[com_fields] 0 Invalid controller: name='article', format='' #13267

waader opened this issue Dec 18, 2016 · 10 comments

Comments

@waader
Copy link
Contributor

waader commented Dec 18, 2016

Steps to reproduce the issue

With current staging I added two field groups with a text field assigned to each group. I also added a category that I assigned to both fields.

Then I added an article and assigned it the newly created category. That went fine but when I added another article with the newly created category I got this error:

0 Invalid controller: name='article', format=''

Tested with mysql.

Expected result

Actual result

System information (as much as possible)

Additional comments

@Bakual
Copy link
Contributor

Bakual commented Dec 18, 2016

Can you tell us what URL you had in the browser when that error occured? Sounds unrelated to fields to me because com_fields doesn't deal with URLs but this error comes from a wrong URL.

@waader
Copy link
Contributor Author

waader commented Dec 19, 2016

Today I tried to reproduce the error which proved to be not an easy task. Finally I succeeded. When adding an article I selected a category and I had to hit immediatly the "Save & Close" Button afterwards. Now the error is thrown. And the URL is ...

http://xyz/joomla37/administrator/index.php?return=aHR0cDovL2xvY2FsaG9zdC9qb29tbGEzNy9hZG1pbmlzdHJhdG9yL2luZGV4LnBocD9vcHRpb249Y29tX2NvbnRlbnQmdmlldz1hcnRpY2xlJmxheW91dD1lZGl0&option=com_fields&task=field.storeform&context=com_content.article&formcontrol=jform

@Bakual
Copy link
Contributor

Bakual commented Dec 19, 2016

Ah, if you select a category, I think com_field does a reload because the available fields may have changed. You interefered with that reload and got stuck between chair and table.
@laoneo Do you think that is correct?
We could maybe add the "loading spinner" so it is apparent that something is happening?

@laoneo
Copy link
Member

laoneo commented Dec 20, 2016

Yes it is correct, when you hit the save button before the page got reloaded, then you can land it that error.

@tonypartridge
Copy link
Contributor

I Suggest we disable save button on category change and enable on category change finished?

@ggppdk
Copy link
Contributor

ggppdk commented Dec 21, 2016

I Suggest we disable save button on category change and enable on category change finished?

About disabling save button, or hiding the toolbar, agreed it is an option
but there is no "category change finished",

because the form submits
and a new page is loaded by the browser, old page is gone

It appears as if the page remains the same, but actually it is a new page, a new form that loads the values that had been entered by the user


Solution, just hide the outer form container and append a div under body with a loading message
then continue with the form submission

Or just add a grayed overlay over the form with a centered loading message

e.g. the following can be shown till the new page appears

loading_please_wait

@tonypartridge
Copy link
Contributor

tonypartridge commented Dec 21, 2016 via email

@laoneo
Copy link
Member

laoneo commented Dec 21, 2016

Can we add a UX label here that they can come up with a proper solution?

@ggppdk
Copy link
Contributor

ggppdk commented Dec 21, 2016

I have made a PR please click on it to see the picture and comment on it

e.g.
comment about
-- place to add styles, or tell me if an overlay CSS class already exists in Joomla
-- better message text

@zero-24
Copy link
Contributor

zero-24 commented Dec 21, 2016

Closing as we have Code to comment on. Thanks!

@zero-24 zero-24 closed this as completed Dec 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants