Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module positions not always translated #12758

Closed
brianteeman opened this issue Nov 5, 2016 · 4 comments
Closed

Module positions not always translated #12758

brianteeman opened this issue Nov 5, 2016 · 4 comments

Comments

@brianteeman
Copy link
Contributor

brianteeman commented Nov 5, 2016

Steps to reproduce the issue

Go to the module manager and open the search filters
You will see that the list of positions include Position-7 and Position-8

image

Open a module and go to the list of available positions and you will see it is listed WITH its language string as well - which is much better and I am sure is the intended behaviour (why else have the strings in the template language file?

image

Scroll a bit further down that list and if you have a module published in Position-7 you will see it in the list of Active Positions but again without the translation

image

The same is true in lots of places - I just highlighted some obvious ones

Expected result

Actual result

System information (as much as possible)

Additional comments

@Bakual
Copy link
Contributor

Bakual commented Nov 5, 2016

It can be a bit tricky because the positions are defined and (optionally) translated by the templates. Now each template may have a different name for the same position-7 position, they may even be in different positions (eg one left, the other right). Which translation would you choose?
That's why it isn't translated for "active positions" and the filters. Because they can come from any template. However in the module form, you have the positions grouped by template and thus they can be translated.

@brianteeman
Copy link
Contributor Author

Just seemed odd to me that we have the option to translate the positions
but we rarely use the translation (or we use it inconsistently)

On 5 November 2016 at 13:22, Thomas Hunziker [email protected]
wrote:

It can be a bit tricky because the positions are defined and (optionally)
translated by the templates. Now each template may have a different name
for the same position-7 position, they may even be in different positions
(eg one left, the other right). Which translation would you choose?
That's why it isn't translated for "active positions" and the filters.
Because they can come from any template. However in the module form, you
have the positions grouped by template and thus they can be translated.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12758 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bS_3xu0aBKPteOmI83TB-F6q46tks5q7IMwgaJpZM4KqHEs
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

@andrepereiradasilva
Copy link
Contributor

andrepereiradasilva commented Nov 5, 2016

i actually made a poc for this (see andrepereiradasilva#99), but is as @Bakual says, will not be totally correct (altough i first find the position in the home template style which probably would cover more than 95% of cases).

@brianteeman
Copy link
Contributor Author

So long and farewell

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants