Skip to content

Commit

Permalink
[4.0] [a11y] com_users icons (#21468)
Browse files Browse the repository at this point in the history
While testing #21441 (which is not related to this pr) I spotted that we missed three icons that should have aria-hidden applied to them

The three icons can be seen in the admin when listing users

-  icon to add a note for the user.
-  icon to filter the notes list. You will need to create some notes first
-  number of notes for the user. You will need to create some notes first
  • Loading branch information
brianteeman authored and wilsonge committed Aug 8, 2018
1 parent a4769e6 commit 978b771
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions administrator/components/com_users/helpers/html/users.php
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ public static function addNote($userId)
$title = Text::_('COM_USERS_ADD_NOTE');

return '<a href="' . Route::_('index.php?option=com_users&task=note.add&u_id=' . (int) $userId)
. '" class="hasTooltip btn btn-secondary btn-sm" title="' . $title . '"><span class="fa fa-plus">'
. '" class="hasTooltip btn btn-secondary btn-sm" title="' . $title . '"><span class="fa fa-plus" aria-hidden="true">'
. '</span> ' . $title . '</a>';
}

Expand All @@ -86,7 +86,7 @@ public static function filterNotes($count, $userId)
$title = Text::_('COM_USERS_FILTER_NOTES');

return '<a href="' . Route::_('index.php?option=com_users&view=notes&filter[search]=uid:' . (int) $userId)
. '" class="dropdown-item"><span class="fa fa-list"></span> ' . $title . '</a>';
. '" class="dropdown-item"><span class="fa fa-list" aria-hidden="true"></span> ' . $title . '</a>';
}

/**
Expand All @@ -109,7 +109,7 @@ public static function notes($count, $userId)
$title = Text::plural('COM_USERS_N_USER_NOTES', $count);

return '<a href="#userModal_' . (int) $userId . '" id="modal-' . (int) $userId
. '" data-toggle="modal" class="dropdown-item"><span class="fa fa-eye"></span> ' . $title . '</a>';
. '" data-toggle="modal" class="dropdown-item"><span class="fa fa-eye" aria-hidden="true"></span> ' . $title . '</a>';
}

/**
Expand Down

0 comments on commit 978b771

Please sign in to comment.