Remove if/else in user debug models that can never hit else conditions (

#21188)
joomla · Jul 20, 2018 · 7b73d5f · 7b73d5f
1 parent 3d713fe
commit 7b73d5f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 26 deletions.
diff --git a/administrator/components/com_users/models/debuggroup.php b/administrator/components/com_users/models/debuggroup.php
@@ -78,19 +78,8 @@ public function getItems()
 				foreach ($actions as $action)
 				{
 					$name = $action[0];
-					$level = $action[1];
-
-					// Check that we check this action for the level of the asset.
-					if ($level === null || $level >= $asset->level)
-					{
-						// We need to test this action.
-						$asset->checks[$name] = JAccess::checkGroup($groupId, $name, $asset->name);
-					}
-					else
-					{
-						// We ignore this action.
-						$asset->checks[$name] = 'skip';
-					}
+
+					$asset->checks[$name] = JAccess::checkGroup($groupId, $name, $asset->name);
 				}
 			}
 		}

diff --git a/administrator/components/com_users/models/debuguser.php b/administrator/components/com_users/models/debuguser.php
@@ -79,19 +79,8 @@ public function getItems()
 				foreach ($actions as $action)
 				{
 					$name = $action[0];
-					$level = $action[1];
-
-					// Check that we check this action for the level of the asset.
-					if ($level === null || $level >= $asset->level)
-					{
-						// We need to test this action.
-						$asset->checks[$name] = $user->authorise($name, $asset->name);
-					}
-					else
-					{
-						// We ignore this action.
-						$asset->checks[$name] = 'skip';
-					}
+
+					$asset->checks[$name] = $user->authorise($name, $asset->name);
 				}
 			}
 		}