[4.0] Add Controller suffix to extension controllers (#17624)

* Add Controller suffix to extension controllers * Support legacy classes
joomla · Aug 24, 2017 · 70a6e43 · 70a6e43
1 parent 2dd9745
commit 70a6e43
Show file tree

Hide file tree

Showing 8 changed files with 32 additions and 11 deletions.
diff --git a/...ponents/com_banners/Controller/Banner.php → ...m_banners/Controller/BannerController.php b/...ponents/com_banners/Controller/Banner.php → ...m_banners/Controller/BannerController.php
@@ -18,7 +18,7 @@
  *
  * @since  1.6
  */
-class Banner extends Form
+class BannerController extends Form
 {
 	/**
 	 * The prefix to use with controller messages.

diff --git a/...onents/com_banners/Controller/Banners.php → ..._banners/Controller/BannersController.php b/...onents/com_banners/Controller/Banners.php → ..._banners/Controller/BannersController.php
@@ -20,7 +20,7 @@
  *
  * @since  1.6
  */
-class Banners extends Admin
+class BannersController extends Admin
 {
 	/**
 	 * The prefix to use with controller messages.

diff --git a/...ponents/com_banners/Controller/Client.php → ...m_banners/Controller/ClientController.php b/...ponents/com_banners/Controller/Client.php → ...m_banners/Controller/ClientController.php
@@ -17,7 +17,7 @@
  *
  * @since  1.6
  */
-class Client extends Form
+class ClientController extends Form
 {
 	/**
 	 * The prefix to use with controller messages.

diff --git a/...onents/com_banners/Controller/Clients.php → ..._banners/Controller/ClientsController.php b/...onents/com_banners/Controller/Clients.php → ..._banners/Controller/ClientsController.php
@@ -17,7 +17,7 @@
  *
  * @since  1.6
  */
-class Clients extends Admin
+class ClientsController extends Admin
 {
 	/**
 	 * The prefix to use with controller messages.

diff --git a/...nts/com_banners/Controller/Controller.php → ..._banners/Controller/DisplayController.php b/...nts/com_banners/Controller/Controller.php → ..._banners/Controller/DisplayController.php
@@ -18,7 +18,7 @@
  *
  * @since  1.6
  */
-class Controller extends BaseController
+class DisplayController extends BaseController
 {
 	/**
 	 * The default view.

diff --git a/...ponents/com_banners/Controller/Tracks.php → ...m_banners/Controller/TracksController.php b/...ponents/com_banners/Controller/Tracks.php → ...m_banners/Controller/TracksController.php
@@ -11,14 +11,14 @@
 defined('_JEXEC') or die;
 
 use Joomla\CMS\Application\ApplicationHelper;
-use Joomla\CMS\Controller\Controller as BaseController;
+use Joomla\CMS\Controller\Controller;
 
 /**
  * Tracks list controller class.
  *
  * @since  1.6
  */
-class Tracks extends BaseController
+class TracksController extends Controller
 {
 	/**
 	 * The prefix to use with controller messages.

diff --git a/libraries/src/Controller/Form.php b/libraries/src/Controller/Form.php
@@ -93,12 +93,21 @@ public function __construct($config = array(), MvcFactoryInterface $factory = nu
 		{
 			$r = null;
 
-			if (!preg_match('/(.*)Controller(.*)/i', get_class($this), $r))
+			$match = 'Controller';
+
+			// If there is a namespace append a backslash
+			if (strpos(get_class($this), '\\'))
+			{
+				$match .= '\\\\';
+			}
+
+			if (!preg_match('/(.*)' . $match . '(.*)/i', get_class($this), $r))
 			{
 				throw new \Exception(\JText::_('JLIB_APPLICATION_ERROR_CONTROLLER_GET_NAME'), 500);
 			}
 
-			$this->context = str_replace('\\', '', strtolower($r[2]));
+			// Remove the backslashes and the suffix controller
+			$this->context = str_replace(array('\\', 'controller'), '', strtolower($r[2]));
 		}
 
 		// Guess the item view as the context.

diff --git a/libraries/src/Dispatcher/Dispatcher.php b/libraries/src/Dispatcher/Dispatcher.php
@@ -149,7 +149,7 @@ public function dispatch()
 		else
 		{
 			// Do we have a controller?
-			$controller = $this->input->get('controller', 'controller');
+			$controller = $this->input->get('controller', 'display');
 			$task       = $command;
 		}
 
@@ -199,7 +199,19 @@ public function getController($name, $client = null, $config = array())
 		// Set up the client
 		$client = $client ? $client : ucfirst($this->app->getName());
 
-		$controllerClass = $namespace . $client . '\\Controller\\' . ucfirst($name);
+		$controllerClass = $namespace . $client . '\\Controller\\' . ucfirst($name) . 'Controller';
+
+		// @todo Remove me when core extensions are converted
+		if (!class_exists($controllerClass))
+		{
+			$controllerClass = $namespace . $client . '\\Controller\\' . ucfirst($name);
+		}
+
+		// @todo Remove me when core extensions are converted
+		if (!class_exists($controllerClass) && $name == 'display')
+		{
+			$controllerClass = $namespace . $client . '\\Controller\\Controller';
+		}
 
 		if (!class_exists($controllerClass))
 		{