Skip to content

Commit

Permalink
[4.0] Imported google fonts without the use of @import (#23682)
Browse files Browse the repository at this point in the history
  • Loading branch information
hardik-codes authored and wilsonge committed Nov 28, 2019
1 parent 1821dfd commit 551e356
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 4 additions & 0 deletions templates/cassiopeia/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,10 @@

// Load specific language related CSS
HTMLHelper::_('stylesheet', 'language/' . $lang->getTag() . '/' . $lang->getTag() . '.css', array('version' => 'auto'));
HTMLHelper::_('stylesheet', 'https://fonts.googleapis.com/css?family=Fira+Sans:400', []);

// Preload the stylesheet for the font, actually we need to preload the font
$this->getPreloadManager()->preload('https://fonts.googleapis.com/css?family=Fira+Sans:400', array('as' => 'stylesheet'));

// Logo file or site title param
if ($this->params->get('logoFile'))
Expand Down
2 changes: 0 additions & 2 deletions templates/cassiopeia/scss/blocks/_global.scss
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
// Global

@import url('https://fonts.googleapis.com/css?family=Fira+Sans:400'); // @TODO - Move to script tag once webfontloader added to core.js

html {
font-size: $font-size-root;
}
Expand Down

0 comments on commit 551e356

Please sign in to comment.