Skip to content

Commit

Permalink
Fix early exit from foreach in JForm::removeGroup
Browse files Browse the repository at this point in the history
The method is supposed to remove all instances of <fields> element but it exits the loop on first iteration only. Looks like a quick copy-paste from removeField may have caused this.
  • Loading branch information
izharaazmi authored Aug 31, 2016
1 parent 6e1be22 commit 3ef9036
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions libraries/joomla/form/form.php
Original file line number Diff line number Diff line change
Expand Up @@ -916,11 +916,9 @@ public function removeGroup($group)
{
$dom = dom_import_simplexml($element);
$dom->parentNode->removeChild($dom);

return true;
}

return false;
return true;
}

/**
Expand Down

0 comments on commit 3ef9036

Please sign in to comment.