php 7.2 fix for count (#19135)

* php 7.2 fix for count PR for #19125 PR for #19126 Can you please test this @Quy - I dont have php 7.2 installed yet If these work then there are lots of other places to be fixed http://php.net/manual/en/migration72.incompatible.php#migration72.incompatible.warn-on-non-countable-types * change to !is_array * chnages as requested
joomla · Jan 8, 2018 · 3d15331 · 3d15331
1 parent a8cf40f
commit 3d15331
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/components/com_contact/models/categories.php b/components/com_contact/models/categories.php
@@ -93,7 +93,7 @@ protected function getStoreId($id = '')
 	 */
 	public function getItems()
 	{
-		if (!count($this->_items))
+		if ($this->_items === null)
 		{
 			$app = JFactory::getApplication();
 			$menu = $app->getMenu();

diff --git a/components/com_newsfeeds/models/categories.php b/components/com_newsfeeds/models/categories.php
@@ -95,7 +95,7 @@ protected function getStoreId($id = '')
 	 */
 	public function getItems()
 	{
-		if (!count($this->_items))
+		if ($this->_items === null)
 		{
 			$app = JFactory::getApplication();
 			$menu = $app->getMenu();