Fix issue with InstantiateNewClassesSniff #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following line would trigger issues with the InstantiateNewClassesSniff: $model = new JModelDatabase(new JRegistry, JFactory::getDbo()); This incorrectly finds the JFactory::getDbo() parenthesis and assumes they're there for the JRegistry call. This pull request adds the comma to the list of escape tokens to reset the call.
LouisLandry
added a commit
that referenced
this pull request
Jun 18, 2012
Fix issue with InstantiateNewClassesSniff
nibra
referenced
this pull request
in GreenCape/coding-standards
Oct 22, 2015
wilsonge
pushed a commit
to wilsonge/coding-standards
that referenced
this pull request
Oct 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following line would trigger issues with the InstantiateNewClassesSniff:
$model = new JModelDatabase(new JRegistry, JFactory::getDbo());
This incorrectly finds the JFactory::getDbo() parenthesis and assumes they're there for the JRegistry call. This pull request adds the comma to the list of escape tokens to reset the call.