This repository has been archived by the owner on Jan 25, 2021. It is now read-only.
Several improvements to solve several issues #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
. Remove display:grid for top and bottom positions . Move rtl definition for footer to _footer.scss ([dir=rtl] & ) . Add margin to form control-group . Add underline for links without class (e.g. in text) . Change padding and position for mod-list on sidebar . Improve links in mod-menu on sidebar
chmst
approved these changes
Sep 22, 2020
This was referenced Sep 22, 2020
hans2103
reviewed
Sep 22, 2020
hans2103
reviewed
Sep 22, 2020
Created PR joomla/joomla-cms#30737 to remove obsolete styling. When merged this part of the page looks great too. |
|
This last change removes all spacing: The image and it's select box is another issue than the spacing.
|
|
@drmenzelit @hans2103 Please check @chmst 's comment above and agree where to fix it, in this PR here or another one. |
|
The problems with spacing in forms should be solved with last commit. |
|
Tested successfully 👍 |
richard67
approved these changes
Sep 24, 2020
|
I have tested this PR ✅ with success. |
|
No spacing.
|
|
@Quy Could you make a new issue for your comment? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issues #98 #97 #92 .
Summary of Changes
. Remove display:grid for top and bottom positions -> improve display for mod_news on top-a
. Move rtl definition for footer to _footer.scss ([dir=rtl] & )
. Add margin to form control-group - #92
. Add underline for links without class (e.g. in text) -> #98
. Improve underline rules for links on menus -> #97
. Change padding and position for mod-list on sidebar
. Improve links in mod-menu on sidebar
Testing Instructions
Run npm ci