Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Line Height #5

Merged
merged 6 commits into from
Oct 22, 2022
Merged

Implemented Line Height #5

merged 6 commits into from
Oct 22, 2022

Conversation

Shubhamverma2796
Copy link
Collaborator

@Shubhamverma2796 Shubhamverma2796 commented Aug 29, 2022

Summary of changes

Users can increase/decrease line height by clicking on the Increase/decrease line height.

Testing instructions

Just check you are able to increase/decrease lineheight. Do not forget to check for persistent session and reset button.

@apapageorgiou apapageorgiou mentioned this pull request Sep 1, 2022
18 tasks
@apapageorgiou
Copy link
Collaborator

Icons are missing

@apapageorgiou
Copy link
Collaborator

Please, also, capitalize the first letter of each word, similarly to the already typography rules of the toolbar.

e.g. increase line height -> Increase Line Height

@Shubhamverma2796
Copy link
Collaborator Author

Please, also, capitalize the first letter of each word, similarly to the already typography rules of the toolbar.

e.g. increase line height -> Increase Line Height

please see joomla-projects/gsoc22_accessibility-plugin#6

@apapageorgiou
Copy link
Collaborator

Tested successfully

@bembelimen bembelimen merged commit b267927 into dev Oct 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants