Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix chrome in CI #272

Merged
merged 2 commits into from
Aug 31, 2024
+3 −3
Merged

Fix chrome in CI #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5aae439
bump ci
jonhoo Aug 31, 2024
3670792
chromdriver now needs a port number
jonhoo Aug 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/macos-latest-chrome
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
brew install --cask google-chrome
brew install --cask chromedriver
chromedriver &
chromedriver --port=9515 &
2 changes: 1 addition & 1 deletion ci/ubuntu-latest-chrome
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
sudo apt-get update
sudo apt-get install chromium-chromedriver
chromedriver &
chromedriver --port=9515 &
2 changes: 1 addition & 1 deletion ci/windows-latest-chrome.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
npm i puppeteer
npx @puppeteer/browsers install chrome@stable
npx @puppeteer/browsers install chromedriver@stable
Start-Process -FilePath chromedriver
Start-Process -FilePath chromedriver -ArgumentList "--port=9515"
Start-Sleep -Seconds 1
Loading