Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use builder for creating Job #9

Open
wezm opened this issue Mar 18, 2018 · 2 comments
Open

Use builder for creating Job #9

wezm opened this issue Mar 18, 2018 · 2 comments

Comments

@wezm
Copy link
Contributor

wezm commented Mar 18, 2018

Currently setting properties on Job outside of kind and args requires manually building a Job or building a Job with new, then mutating its properties. I'd suggest using a builder to create jobs and make the fields of Job private. My suggested approach would probably be derive_builder.

If this sounds reasonable I'm happy to make this change.

@jonhoo
Copy link
Owner

jonhoo commented Mar 18, 2018

Yeah, that makes a lot of sense! I've been wanting to make that change in accordance with C-BUILDER in the Rust API guidelines too. A PR using derive_builder seems reasonable to me!

@jonhoo
Copy link
Owner

jonhoo commented Oct 22, 2018

@wezm still think you'd like to make this change? I'd be happy to review and merge a change like this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants