Added 'transaction entry number' for log entry #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was originally going to complete #120 with this PR, but I'm going to skip that field for now - it has a field length of 1,000, so it'd have to be a long textarea field, which doesn't seem ideal. |
… feature/log-entry-number
Codecov Report
@@ Coverage Diff @@
## main #127 +/- ##
==========================================
+ Coverage 85.38% 85.40% +0.02%
==========================================
Files 13 13
Lines 2087 2090 +3
==========================================
+ Hits 1782 1785 +3
Misses 305 305
Continue to review full report at Codecov.
|
jongpie
added
Type: Enhancement
…eature/log-entry-number
…eature/log-entry-number # Conflicts: # nebula-logger/main/logger-engine/classes/Logger.cls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new field shows the sequential number of this log entry within the transaction (e.g., the first log entry has 'transaction entry number' == 1, the second entry has number == 2, etc.).
I've thought about adding this field ever since dealing with #85 - it's another way to sort the list of log entries, and also helps with troubleshooting to verify that all expected log entries are created.