Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setting for default save method #125

Merged
merged 20 commits into from
Apr 2, 2021

Conversation

jongpie
Copy link
Owner

@jongpie jongpie commented Mar 31, 2021

Added new custom setting field that controls the default save method used when calling Logger.saveLog(); - previously, it was hardcoded to SaveMethod.EVENT_BUS

Configuring the Default Save Method

  • Added field LoggerSettings__c.DefaultSaveMethod__c so that the default save method used when calling Logger.saveLog() is configurable

**Scope creep: deprecated the field LogEntry__c.MessageTruncated__c, and switched to using Database.DMLOptions.allowFieldTruncation instead of using a private truncateFieldValue() method


Screenshot of new fields 'Default Save Method' field on LoggerSettings__c

image

@jongpie jongpie added this to the Version 4.4.0 milestone Mar 31, 2021
@jongpie jongpie temporarily deployed to Test March 31, 2021 07:02 Inactive
@jongpie jongpie temporarily deployed to Test March 31, 2021 07:29 Inactive
@jongpie jongpie temporarily deployed to Test March 31, 2021 07:45 Inactive
@jongpie jongpie temporarily deployed to Test March 31, 2021 08:06 Inactive
@jongpie jongpie temporarily deployed to Test March 31, 2021 08:08 Inactive
@jongpie jongpie temporarily deployed to Test March 31, 2021 16:22 Inactive
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@d456b92). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #125   +/-   ##
=======================================
  Coverage        ?   85.38%           
=======================================
  Files           ?       13           
  Lines           ?     2087           
  Branches        ?        0           
=======================================
  Hits            ?     1782           
  Misses          ?      305           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d456b92...5de6f3b. Read the comment docs.

Will look into optimizing tests further, but currently, it looks like CodeCov gets partial results when the wait time is exceeded (I think)
@jongpie jongpie temporarily deployed to Test March 31, 2021 18:29 Inactive
@jongpie jongpie added Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Type: Enhancement New feature or request labels Mar 31, 2021
@jongpie jongpie temporarily deployed to Test April 1, 2021 02:14 Inactive
@jongpie jongpie changed the title Added configurable settings for default save method and storing platform events in custom objects Added configurable setting for default save method Apr 1, 2021
@jongpie jongpie temporarily deployed to Test April 1, 2021 03:43 Inactive
@jongpie jongpie temporarily deployed to Test April 1, 2021 04:02 Inactive
@jongpie jongpie changed the base branch from master to dev April 1, 2021 05:17
@jongpie jongpie temporarily deployed to Test April 1, 2021 05:22 Inactive
@jongpie jongpie changed the title Added configurable setting for default save method Added setting for default save method Apr 1, 2021
@jongpie jongpie changed the base branch from dev to main April 1, 2021 13:47
@jongpie jongpie temporarily deployed to Test April 1, 2021 21:49 Inactive
@jongpie jongpie temporarily deployed to Test April 1, 2021 22:19 Inactive
Might re-add it later if needed
@jongpie jongpie temporarily deployed to Test April 2, 2021 05:25 Inactive
@jongpie jongpie merged commit e73942d into main Apr 2, 2021
@jongpie jongpie deleted the feature/more-configurable-settings branch April 2, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layer: Configuration Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant