-
-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added setting for default save method #125
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added Logger.getDefaultSaveMethod()
… in Log__c & LogEntry__c
It makes it easier to see more fields in list views
… truncateFieldValue method
… feature/more-configurable-settings
Codecov Report
@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage ? 85.38%
=======================================
Files ? 13
Lines ? 2087
Branches ? 0
=======================================
Hits ? 1782
Misses ? 305
Partials ? 0 Continue to review full report at Codecov.
|
Will look into optimizing tests further, but currently, it looks like CodeCov gets partial results when the wait time is exceeded (I think)
jongpie
added
Layer: Configuration
Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type
Type: Enhancement
New feature or request
labels
Mar 31, 2021
…some design changes for BigObjects
jongpie
changed the title
Added configurable settings for default save method and storing platform events in custom objects
Added configurable setting for default save method
Apr 1, 2021
jongpie
changed the title
Added configurable setting for default save method
Added setting for default save method
Apr 1, 2021
…eature/more-configurable-settings
Might re-add it later if needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Layer: Configuration
Items related to the custom hierarchy setting LoggerSettings__c or any included custom metadata type
Type: Enhancement
New feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new custom setting field that controls the default save method used when calling
Logger.saveLog();
- previously, it was hardcoded toSaveMethod.EVENT_BUS
Configuring the Default Save Method
LoggerSettings__c.DefaultSaveMethod__c
so that the default save method used when callingLogger.saveLog()
is configurable**Scope creep: deprecated the field
LogEntry__c.MessageTruncated__c
, and switched to usingDatabase.DMLOptions.allowFieldTruncation
instead of using a privatetruncateFieldValue()
methodScreenshot of new fields 'Default Save Method' field on
LoggerSettings__c