[MRG] New widget to adjust default smoothing value in gui #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylansdaniels
force-pushed
the
gui_default_smoothing_field
branch
from
8fe7718 to
0fde5c0
Compare
dylansdaniels
changed the title
ntolley
reviewed
Nov 21, 2024
ntolley
reviewed
Nov 21, 2024
hnn_core/gui/_viz_manager.py
Outdated
| @@ -937,6 +944,11 @@ def data(self): | |||
| "figs": self.figs | |||
| } | |||
|
|
|||
| @property | |||
| def fig_default_params(self): | |||
There was a problem hiding this comment.
Does this need to be @property? Seems like the other ones were created to regroup existing attributes for code cleanliness, whereas here you're just returning self.fig_defaults
There was a problem hiding this comment.
I made it a @Property so I could call it in the test:
viz_smooth_value = gui.viz_manager.fig_default_params['default_smoothing']
ntolley
reviewed
Nov 21, 2024
| gui_smooth_value = gui.fig_default_params['default_smoothing'] | ||
| viz_smooth_value = gui.viz_manager.fig_default_params['default_smoothing'] | ||
|
|
||
| assert gui_smooth_value == new_smoothing |
There was a problem hiding this comment.
It'd be useful to add a similar assert for the original smooth values of the fig_default and viz_manager
There was a problem hiding this comment.
I think I follow you, just updated 👍
Remove commented out code Co-authored-by: Nicholas Tolley <[email protected]>
…e everywhere per the suggestion from @ntolley
asoplata
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title says it all