fix: fixes migrations for untrained skill

Fixes an issue with the accessing the id of untrained skills during migrations
jonepatr · Jan 15, 2021 · e6fdec7 · e6fdec7
1 parent f02caf8
commit e6fdec7
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/module/migration.ts b/src/module/migration.ts
@@ -12,10 +12,13 @@ export class Migration {
   private static async migrateActorData(actor:TwodsixActor):Promise<UpdateData> {
     const updateData:UpdateData = <UpdateData>{};
 
-    let untrainedSkill = actor.getUntrainedSkill();
-    if (!untrainedSkill) {
-      untrainedSkill = await actor.buildUntrainedSkill();
-      updateData['data.untrainedSkill'] = untrainedSkill.id;
+    let untrainedSkill;
+    if (actor.data.type == "traveller") {
+      untrainedSkill = actor.getUntrainedSkill();
+      if (!untrainedSkill) {
+        untrainedSkill = await actor.buildUntrainedSkill();
+        updateData['data.untrainedSkill'] = untrainedSkill._id;
+      }
     }
 
     //TODO Get rid of the untrainedSkill passing
@@ -44,10 +47,10 @@ export class Migration {
       }
     }
 
-    if (actor) {
+    if (actor &&  actor.data.type === "traveller") {
       if (item.type !== 'skills') {
         if (!item.data.skill) { //0.6.84
-          updateData['data.skill'] = untrainedSkill.id;
+          updateData['data.skill'] = untrainedSkill._id;
         }
       }
     }