-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inexact slope solver pH from TA #9
base: main
Are you sure you want to change the base?
Conversation
Gentle bump! :) |
Thanks for this, @briochemc! And sorry I just recently noticed it. I'm not a frequent or (more importantly) adept GitHub user, and I don't seem to get email notifications for new pull requests. Doing my best to change all those things. This is great and particularly beneficial I'm sure for those in the modeling community who really don't want CO2SYS to ever hang when doing a lot of automated computations. I've updated my main branch since this pull request was opened. Will merging this PR revert those commits? Do I need to push those new commits to your master branch before merging? Again, not a particularly adept user :) so let me know what to do! And sorry again for missing this. |
Hi @jonathansharp, No worries! I don't think merging would have reverted anything on your side (unless there is a conflict) but I just updated my branch (I pulled your changes into my branch), so you can now safely merge this if you are happy with it :) Cheers! |
Perfect, thanks! I'm out on vacation this week but I'll review the changes when I return. |
This PR is a follow-up from CO2SYS-MATLAB PR #7. It computes the exact slope used in the Newton solver for determining pH from TA.
This PR also includes some extra script called
compare_against_master
for comparing between versions of CO2-System-Extd. It is similar tocompare_versions
except it only runs the CO2-System-Extd version, with the difference that it uses git to switch between the v3.2.0 tag and the current commit. (Figuring out how to run git inside a script and have it actually take effect took me a while to figure out, hence the numerous commits, which can all be squashed into a single merge commit of course.) Here's the output I get (max relative change since v3.2.0 seems to be of order 1e-7):