Skip to content

Commit

Permalink
[dotnet] default $(SuppressTrimAnalysisWarnings) to true
Browse files Browse the repository at this point in the history
Fixes: dotnet#10887

After bumping to .NET 6 Preview 3, we get hundreds of ILLINK warnings.
This is because of:

dotnet/sdk#16327

We need to default `$(SuppressTrimAnalysisWarnings)` to ignore these
warnings for now.

We should continue to use `TrimMode=link`, as that is the behavior
Xamarin developers get today.
  • Loading branch information
jonathanpeppers committed Mar 25, 2021
1 parent 1812a46 commit 85cbac3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions dotnet/targets/Xamarin.Shared.Sdk.targets
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@
<StartupHookSupport Condition="'$(StartupHookSupport)' == ''">false</StartupHookSupport>
<UseSystemResourceKeys Condition="'$(UseSystemResourceKeys)' == ''">true</UseSystemResourceKeys>
<UseNativeHttpHandler Condition="'$(_PlatformName)' != 'macOS' And '$(UseNativeHttpHandler)' == ''">true</UseNativeHttpHandler>
<SuppressTrimAnalysisWarnings Condition=" '$(SuppressTrimAnalysisWarnings)' == '' ">true</SuppressTrimAnalysisWarnings>
</PropertyGroup>

<PropertyGroup>
Expand Down

0 comments on commit 85cbac3

Please sign in to comment.