Skip to content

Commit

Permalink
tweak wording
Browse files Browse the repository at this point in the history
  • Loading branch information
yihui committed Jun 1, 2021
1 parent 7107c68 commit 74e2f2f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
rmarkdown 2.9
================================================================================

- All HTML dependencies are now correctly supported, included those with only a `href` url in their `src`. Previously, an unjustified error 'path for html_dependency not provided.' was thrown when rendering documents (thanks, @crazycapivara, @matthewstrasiotto, #1805, #1948, #2151).
- All HTML dependencies are now correctly supported, included those with only an `href` component but not `file` component in their `src` attribute. Previously, **rmarkdown** would throw the error `'path for html_dependency not provided'` when rendering documents containing HTML dependencies with `href` components (thanks, @crazycapivara, @matthewstrasiotto, #1805, #1948, #2151).

- Fix an error thrown with output format using a `file_scope` function (like in **bookdown**) (thanks, @rfaelens, #2149).

Expand Down
2 changes: 1 addition & 1 deletion R/html_dependencies.R
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ validate_html_dependency <- function(list) {

# check src path or href are given
if (is.null(list$src)) {
stop("neither path nor href are provided for html_dependency", call. = FALSE)
stop("src for html_dependency not provided", call. = FALSE)
}
if (!is.null(list$src$file)) {
file <- list$src$file
Expand Down

0 comments on commit 74e2f2f

Please sign in to comment.