Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New release #3183

Merged
merged 1 commit into from
Aug 16, 2024
Merged

New release #3183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [5.0.0-release-candidate-10]

- Fix Get.offNamedUntil
- Fix GetObserver

## [5.0.0-release-candidate-9]

- Fix redirectDelegate middleware
Expand Down
8 changes: 5 additions & 3 deletions lib/get_navigation/src/extension_navigation.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ extension ExtensionDialog on GetInterface {
List<Widget>? actions,

// onWillPop Scope
PopInvokedCallback? onWillPop,
PopInvokedWithResultCallback<T>? onWillPop,

// the navigator used to push the dialog
GlobalKey<NavigatorState>? navigatorKey,
Expand Down Expand Up @@ -268,8 +268,10 @@ extension ExtensionDialog on GetInterface {

return dialog<T>(
onWillPop != null
? PopScope(
onPopInvoked: onWillPop,
? PopScope<T>(
onPopInvokedWithResult: (didPop, result) =>
onWillPop(didPop, result),
// onPopInvoked: onWillPop,
child: baseAlertDialog,
)
: baseAlertDialog,
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: get
description: Open screens/snackbars/dialogs without context, manage states and inject dependencies easily with GetX.
version: 5.0.0-release-candidate-9
version: 5.0.0-release-candidate-10
homepage: https://github.com/jonataslaw/getx

environment:
Expand Down
Loading