Misaligned routes and dependencies

[XuJin186]

Describe the bug
When using Get.to() Get uses the current path when registering dependencies, not the path you want to go

To Reproduce
Steps to reproduce the behavior:

1. Run the project
2. Click the Demo1 button
3. void _registerRouteInstance<S>({String tag}) { _routesKey.putIfAbsent(_getKey(S, tag), () => Get.reference); } 检查Get.reference的值
4. See Get.reference is /, it should be /Demo1

Expected behavior
void _registerRouteInstance<S>({String tag}) { _routesKey.putIfAbsent(_getKey(S, tag), () => Get.reference); }
Get.reference When it should /Demo1
Screenshots

Flutter Version:
10.0.18363.1082

Getx Version:
get: ^3.11.1

Describe on which device you found the bug:
Emulator

Minimal reproduce code

void main() {
  runApp(App());
}

class App extends StatelessWidget {
  App({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return GetMaterialApp(
      home: Home(),
    );
  }
}



class Home extends StatelessWidget {
  Home({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Home"),
      ),
      body: Column(
        children: [
          RaisedButton(
            onPressed: () {
              Get.to(Demo1());
            },
            child: Text("Demo1"),
          ),
          RaisedButton(
            onPressed: () {
              Get.to(Demo2());
            },
            child: Text("Demo2"),
          )
        ],
      ),
    );
  }
}


class Demo1Controller extends GetxController {}

class Demo1 extends StatelessWidget {
  final Demo1Controller _demo1controller = Get.put(Demo1Controller());
  Demo1({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Demo1"),
      ),
    );
  }
}

class Demo2Controller extends GetxController {}

class Demo2 extends StatelessWidget {
  final Demo2Controller _demo1controller = Get.put(Demo2Controller());
  Demo2({Key key}) : super(key: key);

  @override
  Widget build(BuildContext context) {
    return Scaffold(
      appBar: AppBar(
        title: Text("Demo2"),
      ),
    );
  }
}

[jonataslaw]

The problem it on:

return GetMaterialApp(
      home: Home(), // It's close home instance
    );

As I mentioned in past issues, the MaterialApp home should not receive a Widget, but a widget function.
Because of this Flutter engineering error, when closing a home instance, you are automatically calling the class's constructor, even before the MaterialApp class's constructor.

There are two ways to resolve this:
1: Using a getter instead of a final instance:
Demo1Controller get _demo1controller => Get.put(Demo1Controller());

2: Using named routes. You can use named routes only for the first widget, if you don't want to use named routes for the entire app:

return GetMaterialApp(
      getPages: [GetPage(name:'/': page:()=> Home())],
    );

[XuJin186]

Thank you for your reply, I have tested the solution you mentioned, and it did not achieve the expected effect

[XuJin186]

The first one is OK, the second one is not OK

[Nipodemos]

@XuJin186 Can you tell us exactly what happened when you used the second option?
It was the exact same problem? It was a different one?

[XuJin186]

@XuJin186 Can you tell us exactly what happened when you used the second option?
It was the exact same problem? It was a different one?

Yes

[Nipodemos]

@XuJin186 Can you tell us exactly what happened when you used the second option?
It was the exact same problem? It was a different one?

Yes

I made three questions, to which one are you answering yes?

[XuJin186]

The second solution is the same as the previous error

[XuJin186]

Because the oral complaint may be unclear, I also provided the test code. Please copy it and run it to see what I said.

[eduardoflorence]

For me it worked when all routes are named and I replaced Get.to with Get.toNamed. In this case the controllers have been removed from memory

getPages: [
  GetPage(name: '/', page: () => Home()),
  GetPage(name: '/demo1', page: () => Demo1()),
  GetPage(name: '/demo2', page: () => Demo2()),
],

@jonataslaw this seems to be a very serious problem, because when we don't use the named routes, the controllers are not removed from memory in the removeDependencyByRoute method

[eduardoflorence]

I remembered the solution now, which was already mentioned in another issue:
@XuJin186, you must put Get.put inside the statelessWidget build method:

  @override
  Widget build(BuildContext context) {
    final Demo2Controller _demo1controller = Get.put(Demo2Controller()); // <- here
    return Scaffold(
      appBar: AppBar(
        title: Text("Demo2"),
      ),
    );
  }

[eduardoflorence]

My answer was based on this comment from @jonataslaw:
#384 (comment)

[XuJin186]

My answer was based on this comment from @jonataslaw:
#384 (comment)

Thank you very much for your reply

[eduardoflorence]

You're welcome @XuJin186, can this issue be closed?

[XuJin186]

You're welcome @XuJin186, can this issue be closed?

I use named routes now, so I don’t know if it can solve the problem. There must be a solution. We are only pursuing the best solution.

[Nipodemos]

Since both @jonataslaw and @eduardoflorence provided solutions and @XuJin186 started to using them, i'll close this