Skip to content

Commit

Permalink
Merge pull request #3183 from jonataslaw/RC-10
Browse files Browse the repository at this point in the history
New release
  • Loading branch information
jonataslaw authored Aug 16, 2024
2 parents f7a6330 + 92dee00 commit fc1619e
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 4 deletions.
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## [5.0.0-release-candidate-10]

- Fix Get.offNamedUntil
- Fix GetObserver

## [5.0.0-release-candidate-9]

- Fix redirectDelegate middleware
Expand Down
8 changes: 5 additions & 3 deletions lib/get_navigation/src/extension_navigation.dart
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ extension ExtensionDialog on GetInterface {
List<Widget>? actions,

// onWillPop Scope
PopInvokedCallback? onWillPop,
PopInvokedWithResultCallback<T>? onWillPop,

// the navigator used to push the dialog
GlobalKey<NavigatorState>? navigatorKey,
Expand Down Expand Up @@ -268,8 +268,10 @@ extension ExtensionDialog on GetInterface {

return dialog<T>(
onWillPop != null
? PopScope(
onPopInvoked: onWillPop,
? PopScope<T>(
onPopInvokedWithResult: (didPop, result) =>
onWillPop(didPop, result),
// onPopInvoked: onWillPop,
child: baseAlertDialog,
)
: baseAlertDialog,
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
name: get
description: Open screens/snackbars/dialogs without context, manage states and inject dependencies easily with GetX.
version: 5.0.0-release-candidate-9
version: 5.0.0-release-candidate-10
homepage: https://github.com/jonataslaw/getx

environment:
Expand Down

0 comments on commit fc1619e

Please sign in to comment.