Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fork] Svelte 5 Support #58

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

TutorLatin
Copy link

Svelte-tiny-virtual-list with runes.

This replaces #43

@rxliuli
Copy link

rxliuli commented Feb 1, 2025

Since the original author seems to have not merged this PR for a long time, should we consider forking this repository and releasing a new npm package until @jonasgeiler has time to review and merge this PR?

@LiamKrenn
Copy link

LiamKrenn commented Feb 20, 2025

for now: https://www.npmjs.com/package/svelte5-tiny-virtual-list

Altough I'm not sure it works - I just published it as is and I'm still experiencing issues.

Would be great if there is an official solution soon @jonasgeiler

@TutorLatin
Copy link
Author

Thanks for the npm package @LiamKrenn
What issues are you experiencing?

@LiamKrenn
Copy link

LiamKrenn commented Feb 21, 2025

@TutorLatin
image
After a few elements, the bottom elements are just hidden. You can't scroll too. Height should be more than enough

@TutorLatin
Copy link
Author

That's weird. Make sure you have migrated all slots to snippets.

@LiamKrenn
Copy link

I did, and it seems like it's a styling error. When more items are in the list, it's scrollable again, but it's weird and you can't scroll to the bottom. Here's a screen recording: https://youtu.be/yKUIum_TrOM

@LiamKrenn
Copy link

@TutorLatin I figured out that it has to do with the height property. With your fork it expects a string, but this breaks things. If you pass a number like height={200} it works again as expected, even though the type check throws an error.

@TutorLatin TutorLatin force-pushed the main branch 2 times, most recently from 20e3b9f to 5f653c8 Compare March 2, 2025 07:49
@ubzor
Copy link

ubzor commented Mar 7, 2025

I did, and it seems like it's a styling error. When more items are in the list, it's scrollable again, but it's weird and you can't scroll to the bottom. Here's a screen recording: https://youtu.be/yKUIum_TrOM

I figured out that it has to do with the height property. With your fork it expects a string, but this breaks things. If you pass a number like height={200} it works again as expected, even though the type check throws an error.

Same problem here. infiniteHandler triggers twice after initial rendering, and after that not triggers anymore. Only first portion of data is rendered, and there are glitches when scrolling up and down.

Setting integers to height attribute is not helping with a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants