Make kibit work with local repos #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general approach here seems flawed since there could be arbitrary important stuff in the upstream project that we ignore, but this at least gets it working with local repos. Some discussion here: technomancy/leiningen#1140
|
This got |
|
Can we get this merged? I'm seeing the same problem. |
|
@overthink looks like you'll have to re-submit the PR against https://github.com/jonase/kibit since this repo is deprecated. |
|
Yep, this one is deprecated, if you open it up against the other one I can take a look. |
|
I did it myself. Would love to see this fixed. |
|
Thanks @devth -- sorry I wasn't able to get to this in time! |
|
@overthink np, it was easy enough to apply your fix :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The general approach here seems flawed since there could be arbitrary
important stuff in the upstream project that we ignore, but this at
least gets it working with local repos.
Some discussion here:
technomancy/leiningen#1140