Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Update to 12.5 compatible stripe pod #286

Closed
wants to merge 7 commits into from

Conversation

mclark4386
Copy link

@mclark4386 mclark4386 commented Apr 28, 2021

@jonasbark
Copy link
Owner

Thanks - can you adjust the changelog and version code as well?

@mclark4386
Copy link
Author

Sorry about that, will do! I'm going to put this in WIP because they haven't release the actual cocoapod yet: stripe/stripe-ios#1795 , hopefully that'll be a quick fix for them and then I'll mark this a ready (was mostly using this PR for testing, sorry I didn't mark it as WIP going into it!)

@mclark4386 mclark4386 changed the title Update to 12.5 compatible stripe pod WIP: Update to 12.5 compatible stripe pod Apr 28, 2021
@mclark4386
Copy link
Author

Updated! Will switch this off of WIP as soon as that pod is released!

@wilpar
Copy link

wilpar commented Apr 28, 2021

Ever notice how things break just when you need 'em?

@jonasbark
Copy link
Owner

Always wait before updating Xcode if you're using Flutter... :)

@chaesung
Copy link

Well according to stripe/stripe-ios#1767, it ain't coming.... would it be possible to move up to version 21.3.1 and change the min iOS version to 11?

@mclark4386
Copy link
Author

about to make those changes to test...

It seems the new v19 isn't coming so going to try to bump to v21 which means a bump to ios 11 min as well
@mclark4386
Copy link
Author

Migration notes here: https://github.com/stripe/stripe-ios/blob/master/MIGRATING.md make it sound like not such a big deal till you notice this link: https://stripe.com/docs/mobile/ios/sdk-21-migration?language=objc
so... yeah... may try to get that working with a find/replace, but this may not be as quick a fix as I hoped.

@mclark4386
Copy link
Author

Well... The good news is it's building again. I'm not positive how to test it besides just building it into my app and trying it... didn't change anymore than I had to (including some deprecations that need to be fixed ASAP), so hopefully it'll be stable? I'll let y'all know if anything comes up.
Going to keep this as WIP at least until my build comes back bug free.

@chaesung
Copy link

Awesome. Hopefully everything works and gets merged.

@ag84ark
Copy link

ag84ark commented Apr 28, 2021

I have applied your changes to my local copy of the plugin, it compiles, and I can run the project, but when i want to use the Stripe add card widget, the app gets killed.
Maybe this is just by me, I have no experience with Swift.
This is what I get, maybe it can help:

2021-04-29 01:06:38.759459+0200 Runner[2065:1172147] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[1]' *** First throw call stack: (0x20342f180 0x2026079f8 0x2033a8bec 0x203330898 0x203322934 0x203322710 0x22f625374 0x22f61e098 0x10d6c0b80 0x10d6c1018 0x10d5c3f38 0x10d5c2b98 0x10d561a00 0x10d5c4648 0x10d5c29f4 0x22f858224 0x22f858628 0x22f7d56bc 0x22f78b8f0 0x22f787d60 0x22fe0d0ac 0x22fdfbbfc 0x22fe28a6c 0x2033c04fc 0x2033bb224 0x2033bb7a0 0x2033bafb4 0x2055bc79c 0x22fe01c38 0x100645628 0x202e7e8e0) *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: '*** -[__NSPlaceholderDictionary initWithObjects:forKeys:count:]: attempt to insert nil object from objects[1]' terminating with uncaught exception of type NSException libc++abi.dylib: terminating with uncaught exception of type NSException

@mclark4386
Copy link
Author

Going to close this because there is a better solution in #284 .

@mclark4386 mclark4386 closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants