-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Update to 12.5 compatible stripe pod #286
Conversation
Thanks - can you adjust the changelog and version code as well? |
Sorry about that, will do! I'm going to put this in WIP because they haven't release the actual cocoapod yet: stripe/stripe-ios#1795 , hopefully that'll be a quick fix for them and then I'll mark this a ready (was mostly using this PR for testing, sorry I didn't mark it as WIP going into it!) |
Updated! Will switch this off of WIP as soon as that pod is released! |
Ever notice how things break just when you need 'em? |
Always wait before updating Xcode if you're using Flutter... :) |
Well according to stripe/stripe-ios#1767, it ain't coming.... would it be possible to move up to version 21.3.1 and change the min iOS version to 11? |
about to make those changes to test... |
It seems the new v19 isn't coming so going to try to bump to v21 which means a bump to ios 11 min as well
Migration notes here: https://github.com/stripe/stripe-ios/blob/master/MIGRATING.md make it sound like not such a big deal till you notice this link: https://stripe.com/docs/mobile/ios/sdk-21-migration?language=objc |
Well... The good news is it's building again. I'm not positive how to test it besides just building it into my app and trying it... didn't change anymore than I had to (including some deprecations that need to be fixed ASAP), so hopefully it'll be stable? I'll let y'all know if anything comes up. |
Awesome. Hopefully everything works and gets merged. |
I have applied your changes to my local copy of the plugin, it compiles, and I can run the project, but when i want to use the Stripe add card widget, the app gets killed.
|
Going to close this because there is a better solution in #284 . |
https://github.com/stripe/stripe-ios/releases/tag/v19.4.1 should hopefully solve #246