Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IgnoreLeadingNaN fix #3547

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

IgnoreLeadingNaN fix #3547

wants to merge 11 commits into from

Conversation

SybexX
Copy link
Collaborator

@SybexX SybexX commented Feb 8, 2025

#3545

Unbenannt

changed (IgnoreLeadingNaN >>>> NUMBERS[j]->IgnoreLeadingNaN)
from:

bool ClassFlowPostProcessing::ReadParameter(FILE* pfile, string& aktparamgraph) {
        .....
        if ((toUpper(_param) == "CHECKDIGITINCREASECONSISTENCY") && (splitted.size() > 1)) {
            if (alphanumericToBoolean(splitted[1])) {
                for (_n = 0; _n < NUMBERS.size(); ++_n) {
                    NUMBERS[_n]->checkDigitIncreaseConsistency = true;
                }
            }
        }
        .....
        if ((toUpper(_param) == "IGNORELEADINGNAN") && (splitted.size() > 1)) {
            IgnoreLeadingNaN = alphanumericToBoolean(splitted[1]);
        }
        .....
}

to:

bool ClassFlowPostProcessing::ReadParameter(FILE* pfile, string& aktparamgraph) {
        .....
        if ((toUpper(_param) == "CHECKDIGITINCREASECONSISTENCY") && (splitted.size() > 1)) {
            handlecheckDigitIncreaseConsistency(splitted[0], splitted[1]);
        }
        .....
        if ((toUpper(_param) == "IGNORELEADINGNAN") && (splitted.size() > 1)) {
            handleIgnoreLeadingNaN(splitted[0], splitted[1]);
        }
        .....
}

@caco3
Copy link
Collaborator

caco3 commented Feb 28, 2025

What is the state of this?
Should we merge it?
Is it complete?
Is there any risk of side effects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants