Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Prometheus/OpenMetrics exporter #3081
add Prometheus/OpenMetrics exporter #3081
Changes from 12 commits
87ecdd5
3e19f8e
a35e928
2a14791
3e17009
2ab4f0a
553c4a1
6d567cc
39371bf
5d82ed2
5bdf08e
a9849b1
c5f3fe3
5718557
9e974ef
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because this has an impact on the memory usage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is some (IMHO: weak) evidence, that this value impacts memory usage:
config.max_uri_handlers = 40;
config.max_uri_handlers = 1040;
I would consider the ~6 Bytes per increment insignificant but we should maybe give some useful info in the comment or remove it altogether.