Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move Wifi, LWIP and BSSI to PSRAM #2117

Merged
merged 1 commit into from
Mar 5, 2023

Conversation

caco3
Copy link
Collaborator

@caco3 caco3 commented Mar 3, 2023

This saves us around 30kBytes of heap!

Some tests I run (same config), chcked after 3 rounds:

  • rolling (39b8b5b): Int Free: 33159, Int Min Free: 10007
  • With CONFIG_SPIRAM_TRY_ALLOCATE_WIFI_LWIP and CONFIG_SPIRAM_ALLOW_BSS_SEG_EXTERNAL_MEMORY: Int Free: 69731, Int Min Free: 63571
    @needs some more testing, but for me I do not see any issue as of now.

@caco3
Copy link
Collaborator Author

caco3 commented Mar 3, 2023

@jomjol @Slider0007 please test

@jomjol
Copy link
Owner

jomjol commented Mar 4, 2023

Can we merge it with the simplified roaming?

@caco3
Copy link
Collaborator Author

caco3 commented Mar 4, 2023

lets first merge the other one and then rebase.

but I do not see a reason it should be an issue

@Slider0007
Copy link
Collaborator

@caco3: No issues so far. It looks really great to see 60k free internal heap :-)

Great finding 👍

@caco3
Copy link
Collaborator Author

caco3 commented Mar 4, 2023

@Slider0007 It was actually you who pointed me to the flags documentation :)

@Slider0007
Copy link
Collaborator

@Slider0007 It was actually you who pointed me to the flags documentation :)

I would say it's teamwork ;-)

@caco3 caco3 marked this pull request as ready for review March 5, 2023 07:43
@caco3 caco3 merged commit 2dfd55e into rolling Mar 5, 2023
@jomjol jomjol deleted the move-wifi-lwip-and-bss-seg-to-psram branch March 6, 2023 06:15
@caco3 caco3 mentioned this pull request Mar 11, 2023
31 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants