Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support saturation & contrast #2048

Merged
merged 3 commits into from
Feb 19, 2023
Merged

Support saturation & contrast #2048

merged 3 commits into from
Feb 19, 2023

Conversation

Slider0007
Copy link
Collaborator

@Slider0007 Slider0007 commented Feb 18, 2023

Add saturation & contrast support --> #1851

  • Add workaround for cam library to support saturation and contrast
    --> Not all requested functions are enabled even if called because bitwise OR logic of the ENABLE BYTE is missing in library. Only latest enable is active. Now registers are written directly to enable neccessary bits. Newer versions of cam library still have the same issue, so same library version is used
  • Add additional error handling to ClassControllCamera
  • Refactor ClassControllCamera.cpp
  • edit_reference.html: Use correct value for contrast setting (saturation value was used before)
  • Limit image quality index to 8...63 to prevent against instabilities at too low values (no change to default value: 12)
  • edit_config_param.html: Adapt parameter quality index, saturation and contrast to changes in firmware

Questions:

  • Any concerns about this workaround?
  • Any concerns changing the lower limit of quality index from 0 to 8?

@jomjol
Copy link
Owner

jomjol commented Feb 19, 2023

To your questions

  1. no concerns - only one question: do we have to take something into account, when we update the esp32cam library?
  2. fine for me!

For me you can remove the draft status.

@Slider0007
Copy link
Collaborator Author

  1. no concerns - only one question: do we have to take something into account, when we update the esp32cam library?

It should be not critical to update the library because the same registers get written than the library do.

@Slider0007 Slider0007 marked this pull request as ready for review February 19, 2023 19:58
@jomjol jomjol merged commit 10da8c4 into rolling Feb 19, 2023
@jomjol jomjol deleted the fix-cam-parameters branch February 19, 2023 20:15
@Slider0007
Copy link
Collaborator Author

@jomjol: We should highlight this change somehow on the changelog because this could have impact on existing camera configurations.

@jomjol
Copy link
Owner

jomjol commented Feb 20, 2023

Done in the changelog from the rolling

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants