*** OLD *** Migrate configuration -> Superseeded by PR2017

[caco3]

Replaced by #2017

---

This PR adds a migration function of some parameters:

• Rename section MakeImage to TakeImage, rename all variables and files accordingly
• Rename Intervall to Interval, rename all variables
• Rename RSSIThreashold to RSSIThreshold, rename all variables
• For all boolean parameters: If they where commented out -> remove the semicolon and set them to their default value (according to their C++ initialization).

The migration function gets called at startup and modifies the config file as needed. If one or mor eparameter needs a migration, store the config.ini as config.bak before any change to it.

Yet to do

• Remove the checkboxes for all boolean parameters in the UI -> @jomjol can you do this? I tried it but failed to understand how it exactly works.
• @jomjol @haverland @Slider0007: Are there other parameters where you think we should rename them? This PR might be a good time to do so.
• Testing

[jomjol]

@jomjol @haverland @Slider0007: Are there other parameters where you think we should rename them? This PR might be a good time to do so.

I started to do so, but as the categories are renamed as well, I could not fully test. Will do this in the next days.

[caco3]

@jomjol You should start with the sd-card/html/edit_config_param.html from this branch, I updated the section/parameters already

[caco3]

@jomjol There was a merge conflict, so I solved it, see d1d2d67

Not sure if I now reverted some of your work!

[jomjol]

@jomjol There was a merge conflict, so I solved it, see d1d2d67

Not sure if I now reverted some of your work!

I think I just corrected it.

[Slider0007]

@caco3: Some discussion topics:

config.ini:
AutoAdjustSummertime --> AFAIK this not used anymore
LogfileRetentionInDays --> maybe LogRetentionPeriod (specially for logging the images, Logfile... is kind of misleading, but renaming this is not a must)
SetRetainFlag --> RetainFlag or RetainMessages(renaming not a must)

[caco3]

config.ini: AutoAdjustSummertime

Stimmt, das wird in der Firmware nirgends mehr verwendet. @jomjol, können wir das löschen?

LogfileRetentionInDays --> maybe LogRetentionPeriod (specially for logging the images, Logfile... is kind of misleading, but renaming this is not a must)

Right.
I would suggest to do it as following:

• Analog/Digits: Here we use it for the training images. I would rename it to RoiImagesRetentionInDays or TrainingImagesRetentionInDays. And I would rename the related parameters as well. Ans also update the default path (eg. /log/analog)
• Debug: Keep LogfileRetentionInDays as is.

SetRetainFlag --> RetainFlag or RetainMessages(renaming not a must)

I would go for RetainMessages

@jomjol, what is LogImageLocation in the section TakeImage used for? Is that storning the whole cam image?

[jomjol]

config.ini: AutoAdjustSummertime

Stimmt, das wird in der Firmware nirgends mehr verwendet. @jomjol, können wir das löschen?

Right, we can delete it

LogfileRetentionInDays --> maybe LogRetentionPeriod (specially for logging the images, Logfile... is kind of misleading, but renaming this is not a must)

Right. I would suggest to do it as following:

* Analog/Digits: Here we use it for the training images. I would rename it to `RoiImagesRetentionInDays` or `TrainingImagesRetentionInDays`. And I would rename the related parameters as well. Ans also update the default path (eg. `/log/analog`)

TrainingImagesRetention... could make the people think, the device is training itself. Therefore I would go for "ROIImages..."

@jomjol, what is LogImageLocation in the section TakeImage used for? Is that storning the whole cam image?

This is used for storing the full images (before cutting) in the directory /log/source

[caco3]

I think we should to a release 14.1 which just the parameter migration.
Release 15 will have a lot of changes which might break stuff. And this way users can go back top v14 without broken parameters.

I will prepare a branch for it.

[caco3]

New PR which only contains the parameter changes: #2017