Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Digit Consistency Check does not work with dig-class11 #2145

Closed
friedpa opened this issue Mar 8, 2023 · 8 comments
Closed

Digit Consistency Check does not work with dig-class11 #2145

friedpa opened this issue Mar 8, 2023 · 8 comments
Assignees
@haverland
Labels
bug Something isn't working

Comments

@friedpa
Copy link

friedpa commented Mar 8, 2023

The Problem

Obwohl Negative Rates nicht erlaubt sind, wird trotzdem ein kleiner Wert als vorher akzeptiert. Interessanterweise wird bei der Rolling Version ab und zu zum Raw Value 0,1 dazugezählt und als Value ausgegeben (inkl. dem setzen des Previous Value Wertes).

grafik
grafik

Version

Development-Branch: rolling (Commit: 1f5d4de+)

Logfile

No Logfile

Expected Behavior

No response

Screenshots

No response

Additional Context

No response
@friedpa friedpa added the bug Something isn't working label Mar 8, 2023
@friedpa
Copy link
Author

friedpa commented Mar 9, 2023 •
edited
Loading

Heute wieder:
grafik
eigentlich müsste da doch ein "negative Rate" Error ausgegeben werden, oder?

Edit:
Kann der Fehler mit "Check Digit Increase Consistency" zusammenhängen, der war früher immer Flase gestzt und jetzt steht er nach 15.0.3 auf true. Habe diesen Parameter nun wieder auf false gesetzt und werde berichten.

@haverland haverland self-assigned this Mar 9, 2023
@haverland
Copy link
Collaborator

Welches Neuronales Netz verwendest du?

@haverland
Copy link
Collaborator

Testfall mit den Werten oben erstellt => kein Fehler.
Man sieht auch, dass der Value den Pre-Value behält. Nur RawValue enthält den gelesenen Wert.
Aber "error" sollte nicht auf "no error" stehen.

@friedpa : Mich würde noch der Parameter ExtendedResolution interessieren neben der Modelart.

@haverland haverland mentioned this issue Mar 9, 2023
Merged
@friedpa
Copy link
Author

friedpa commented Mar 10, 2023

Extended Resolution = false
dig0640s3.ftlite => alt aber hat immer sehr gut funktioniert

@friedpa
Copy link
Author

friedpa commented Mar 10, 2023

Es muss mit dem "Check Digit Increase Consistency" zusammenhängen, da nach setzen auf false der Fehler (bisher) nicht mehr auftritt.

@haverland
Copy link
Collaborator

Danke. Also dig-class11, dann macht auch Check Digit Increase Consistency Sinn als mögliche Quelle.
Ich konnte es nachstellen. Es hat hier gar nichts mit Allow negatives zu tun, sondern mit der Sonderbehandlung Check Digit Consistency, die den Wert verändert.

Hier wird der Pre-Value-Wert aus dem vorherigen Cycle mit dem aktuellen Wert verglichen.
Um dem Fehler auf die Spur zu kommen, müsste ich auch den PreValue Wert (bzw. Value davor) kennen. Viellicht kannst du beim nächsten Mal das Log mitschicken (am besten so lange das Log auf debug stellen).

jomjol pushed a commit that referenced this issue Mar 11, 2023
@haverland
Testcase for #2145 and debug-log (#2151)
512d7f9 
* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled
caco3 added a commit that referenced this issue Mar 12, 2023
@caco3 @haverland
@jomjol @Slider0007
release 15.1.0 (#2172)
7d33c3e 
* Testcase for #2145 and debug-log (#2151)

* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled

* Fix timezone config parser (#2169)

* make sure to parse the whole config line

* fix crash on empty timezone parameter

---------

Co-authored-by: CaCO3 <[email protected]>

* Enhance ROI pages (#2161)

* Check if the ROIs are equidistant. Only if not, untick the checkbox

* renaming

* Check if the ROIs have same y, dy and dx. If so, tick the sync checkbox

* only allow editing space when box is checked

* fix sync check

* show inner frame on all ROIs

* cleanup

* Check if the ROIs have same dy and dx. If so, tick the sync checkbox

* checkbox position

* renaming

* renaming

* show inner frame and cross hairs on all ROIs

* update ROIs on ticking checkboxes

* show timezone hint

* fix deleting last ROI

* cleanup

---------

Co-authored-by: CaCO3 <[email protected]>

* restart timeout on progress, catch error (#2170)

* restart timeout on progress, catch error

* .

---------

Co-authored-by: CaCO3 <[email protected]>

* BugFix #2167

* Release 15.1 preparations (#2171)

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update changelog

* Fix links to PR

* Formating

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

---------

Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>

---------

Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: jomjol <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
caco3 pushed a commit that referenced this issue Mar 14, 2023
@haverland
Sort model files in configuration combobox (#2189)
ab0fc72 
* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled

* Sort model files in combobox
jomjol added a commit that referenced this issue Mar 19, 2023
@jomjol @haverland
@caco3 @Slider0007
Implement InfluxDBv1 and minor changes (#2211)
b5e0d6e 
* Testcase for #2145 and debug-log (#2151)

* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled

* Fix timezone config parser (#2169)

* make sure to parse the whole config line

* fix crash on empty timezone parameter

---------

Co-authored-by: CaCO3 <[email protected]>

* Enhance ROI pages (#2161)

* Check if the ROIs are equidistant. Only if not, untick the checkbox

* renaming

* Check if the ROIs have same y, dy and dx. If so, tick the sync checkbox

* only allow editing space when box is checked

* fix sync check

* show inner frame on all ROIs

* cleanup

* Check if the ROIs have same dy and dx. If so, tick the sync checkbox

* checkbox position

* renaming

* renaming

* show inner frame and cross hairs on all ROIs

* update ROIs on ticking checkboxes

* show timezone hint

* fix deleting last ROI

* cleanup

---------

Co-authored-by: CaCO3 <[email protected]>

* restart timeout on progress, catch error (#2170)

* restart timeout on progress, catch error

* .

---------

Co-authored-by: CaCO3 <[email protected]>

* BugFix #2167

* Release 15.1 preparations (#2171)

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update changelog

* Fix links to PR

* Formating

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

---------

Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>

* fix typo

* Replace relative documentation links with absolute ones pointing to the external documentation (#2180)

Co-authored-by: CaCO3 <[email protected]>

* Sort model files in configuration combobox (#2189)

* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled

* Sort model files in combobox

* reboot task - increase stack size (#2201)

Avoid stack overflow

* Update interface_influxdb.cpp

* Update Changelog.md

---------

Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
caco3 added a commit that referenced this issue Mar 23, 2023
@caco3 @haverland
@jomjol @Slider0007
Release 15.1.1 (#2232)
03c84a1 
* Testcase for #2145 and debug-log (#2151)

* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled

* Fix timezone config parser (#2169)

* make sure to parse the whole config line

* fix crash on empty timezone parameter

---------

Co-authored-by: CaCO3 <[email protected]>

* Enhance ROI pages (#2161)

* Check if the ROIs are equidistant. Only if not, untick the checkbox

* renaming

* Check if the ROIs have same y, dy and dx. If so, tick the sync checkbox

* only allow editing space when box is checked

* fix sync check

* show inner frame on all ROIs

* cleanup

* Check if the ROIs have same dy and dx. If so, tick the sync checkbox

* checkbox position

* renaming

* renaming

* show inner frame and cross hairs on all ROIs

* update ROIs on ticking checkboxes

* show timezone hint

* fix deleting last ROI

* cleanup

---------

Co-authored-by: CaCO3 <[email protected]>

* restart timeout on progress, catch error (#2170)

* restart timeout on progress, catch error

* .

---------

Co-authored-by: CaCO3 <[email protected]>

* BugFix #2167

* Release 15.1 preparations (#2171)

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update changelog

* Fix links to PR

* Formating

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

* Update Changelog.md

---------

Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>

* fix typo

* Replace relative documentation links with absolute ones pointing to the external documentation (#2180)

Co-authored-by: CaCO3 <[email protected]>

* Sort model files in configuration combobox (#2189)

* new models ana-cont-11.0.5, ana-class100-1.5.7, dig-class100-1.6.0

* Testcase for #2145
Added debug log, if allowNegativeRates is handeled

* Sort model files in combobox

* reboot task - increase stack size (#2201)

Avoid stack overflow

* Update interface_influxdb.cpp

* Update Changelog.md

* Show PSRAM usage (#2206)

* centralize PSRAM usage (application code only)

* update logging

* update logging

* fix use after free

* initialize buffer

* free rgb_image before ussing it for new allocation

* use wrapper function

* switch log level to debug

* .

* undo adding free() calls

* .

* add names to all CImage instances

* .

* .

* .

* revert changes of stbi_image_free() with free_psram_heap() on the places where is is not in PSRAM

* .

* typos

* typo

* Added MQTT Outbox explanation/warning

* added CONFIG_SPIRAM_USE_MEMMAP explanation

---------

Co-authored-by: CaCO3 <[email protected]>

* Disable custom MQTT Outbox. This also moves the MQTT Publishing memory usage back to the internal RAM!

* log MQTT connection refused reasons (#2216)

* Revert PSRAM usage as it lead to memory fragmentation. (#2224)

See #2200 for details

Co-authored-by: CaCO3 <[email protected]>

* Fix missing value data in graph (#2230)

* fix missing value data

---------

Co-authored-by: CaCO3 <[email protected]>

* Update Changelog.md (#2231)

---------

Co-authored-by: Frank Haverland <[email protected]>
Co-authored-by: CaCO3 <[email protected]>
Co-authored-by: jomjol <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
Co-authored-by: Slider0007 <[email protected]>
@caco3 caco3 changed the title Negativ Rate - Allow negativ Rates = False Digit Consistency Check does not work with dig-class11 Apr 23, 2023
@caco3
Copy link
Collaborator

caco3 commented Apr 23, 2023

I am changing it to a discussion

@caco3
Copy link
Collaborator

caco3 commented Apr 23, 2023

@friedpa If you see it again, fell free to comment again for further diagnosis.

Repository owner locked and limited conversation to collaborators Apr 23, 2023
@caco3 caco3 converted this issue into discussion #2343 Apr 23, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Assignees

@haverland haverland

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@haverland @caco3 @friedpa