Fix for #183

[alexnaiman]

Fixing #183

Removed all the requiring cycles by changing all to use directly the NativeModules

Thanks to #183 (comment)

[brian-perlego]

Any update on approving the PR ?

[arthwood]

Consider having module in polyfill/RNFetchBlob.js:

import { NativeModules } from 'react-native';

const RNFetchBlob = NativeModules.RNFetchBlob

export default RNFetchBlob;

Seems like trivial module but allows to have single shared source.

[zabojad]

Hi there! If everything is OK, could be great to merge it really...

[penghouho]

Anything else we need to get this merge? thanks

[peanudge]

Please merge this pr~ 🥲. I don`t want to see warning about it.

[clintisgoodboy]

Please merge this pr~ 🥲. I don`t want to see warning about it.

[rpenfold]

This PR has already been merged to master. It hasn't yet been published to NPM; we're working on that. In the meantime you can point your package.json entry to the git commit or wait for the next package version. I'm hoping to publish a beta version in the next week or so that will contain this change and many others that have recently been merged.

[hipages-ligang]

Haven't publish to NPM?

[rpenfold]

Yeah, I apologize for the delay. It took a while to get the appropriate permissions and sort out a few things. I just published [email protected] as a beta package to NPM. Unfortunately, at the moment we are not particularly well-equipped to test thoroughly ourselves, so upgrade at your own risk. We intend to begin testing it internally with our software, but those tests should not be considered comprehensive.

Since inheriting this project, I am not familiar with testing strategies that have been used in the past. I'll continue to look into this and other solutions to enhance testability. Unfortunately, I don't have a lot of time to dedicate to this but I'm hoping to at least begin to regain some momentum.