-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require cycle #296
require cycle #296
Conversation
This fixed the warning for "require cycle" on newer React-Versions
when is this going to be merged?? :S i hate those darn warnings. |
why was that import even there if it is not used anyway? |
does anyone have joltup's contact?? so we can ask him to merge this PR? |
Looks like you may have trouble with these: rn-fetch-blob/polyfill/XMLHttpRequest.js Line 169 in 6c275ad
rn-fetch-blob/polyfill/XMLHttpRequest.js Lines 189 to 196 in 6c275ad
|
In rn 59 it should be fine so we'd have to lock the next version tot that and up. It could also be solved without rn 59 but is it worth the effort? In that case this pr would not suffice. |
any updates here? |
The RNFetchBlob import is used multiple times in this file, one call to RNFetchBlob.wrap and a second call to RNFetchBlob.config - This PR would break this file |
any updates? |
@@ -2,7 +2,6 @@ | |||
// Use of this source code is governed by a MIT-style license that can be | |||
// found in the LICENSE file. | |||
|
|||
import RNFetchBlob from '../index.js' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The RNFetchBlob import is used multiple times in this file, one call to RNFetchBlob.wrap
and a second call to RNFetchBlob.config
- This PR would break this file
This fixed the warning for "require cycle" on newer React-Versions