Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

require cycle #296

Closed
wants to merge 1 commit into from
Closed

require cycle #296

wants to merge 1 commit into from

Conversation

suther
Copy link

@suther suther commented Jan 24, 2019

This fixed the warning for "require cycle" on newer React-Versions

This fixed the warning for "require cycle" on newer React-Versions
@msqar
Copy link

msqar commented Feb 21, 2019

when is this going to be merged?? :S i hate those darn warnings.

@vitorverasm vitorverasm mentioned this pull request Feb 21, 2019
@ThaJay
Copy link

ThaJay commented Feb 22, 2019

why was that import even there if it is not used anyway?

@msqar
Copy link

msqar commented Feb 22, 2019

does anyone have joltup's contact?? so we can ask him to merge this PR?

@el-lsan
Copy link

el-lsan commented Mar 7, 2019

@Traviskn, @joltup Could you please consider this PR. 🙌

@alpha0010
Copy link

Looks like you may have trouble with these:

body = RNFetchBlob.wrap(blob.getRNFetchBlobRef())
this._task = RNFetchBlob
.config({
auto: true,
timeout : this._timeout,
increment : this._increment,
binaryContentTypes : XMLHttpRequest.binaryContentTypes
})
.fetch(_method, _url, _headers, body)

@ThaJay
Copy link

ThaJay commented Mar 14, 2019

In rn 59 it should be fine so we'd have to lock the next version tot that and up.
#183 (comment)

It could also be solved without rn 59 but is it worth the effort? In that case this pr would not suffice.

andreasbergqvist added a commit to andreasbergqvist/rn-fetch-blob that referenced this pull request Apr 5, 2019
andreasbergqvist added a commit to andreasbergqvist/rn-fetch-blob that referenced this pull request Apr 5, 2019
@mayconmesquita
Copy link

any updates here?

@Traviskn
Copy link

The RNFetchBlob import is used multiple times in this file, one call to RNFetchBlob.wrap and a second call to RNFetchBlob.config - This PR would break this file

@marcorm
Copy link

marcorm commented Oct 3, 2019

any updates?

@@ -2,7 +2,6 @@
// Use of this source code is governed by a MIT-style license that can be
// found in the LICENSE file.

import RNFetchBlob from '../index.js'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The RNFetchBlob import is used multiple times in this file, one call to RNFetchBlob.wrap and a second call to RNFetchBlob.config - This PR would break this file

@Traviskn Traviskn closed this Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants