Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workers tasks): get_workers works with docker ps header #211

Merged
merged 1 commit into from
May 16, 2023

Conversation

ternel
Copy link
Member

@ternel ternel commented May 16, 2023

Hi there,

Thanks for this awesome tool folks!

I have an issue with the get_workers function, I think it's from a new docker version, but not sure. /shrug

$ docker --version
Docker version 23.0.6

$ inv start 
Encountered a bad command exit code!

Command: 'docker update --restart=no NAMES     IMAGE     CREATED ago   STATUS    COMMAND'

Exit code: 1

Stdout:



Stderr:

Error response from daemon: No such container: NAMES
Error response from daemon: No such container: IMAGE
Error response from daemon: No such container: CREATED
Error response from daemon: No such container: ago
Error response from daemon: No such container: STATUS
Error response from daemon: No such container: COMMAND

$ docker ps -a --filter "label=docker-starter.worker.lookcycle" --quiet
NAMES     IMAGE     CREATED ago   STATUS    COMMAND

I've updated the function to check if the header is displayed. (Maybe a better way to do this?)

@ternel ternel requested review from lyrixx and pyrech May 16, 2023 07:35
@ternel ternel self-assigned this May 16, 2023
@pyrech
Copy link
Member

pyrech commented May 16, 2023

Thanks

@pyrech pyrech merged commit 97132ec into main May 16, 2023
@pyrech pyrech deleted the fix/docker-ps-format branch May 16, 2023 07:42
@ternel
Copy link
Member Author

ternel commented May 26, 2023

--quiet fixed in docker 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants