This repository has been archived by the owner on Aug 10, 2022. It is now read-only.
Solucionados los issues #11 & #14 & sonar análisis. #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alefq
suggested changes
May 11, 2017
| @@ -35,6 +34,11 @@ | |||
| * Final class: to prevent someone from accidentally instantiating the class, we give it an | |||
| * empty constructor. | |||
| */ | |||
| public void ipfromsystem(){ | |||
There was a problem hiding this comment.
Code Conventions should follow Oracle recommendations http://www.oracle.com/technetwork/java/javase/documentation/codeconventions-135099.html#367
alefq
suggested changes
May 11, 2017
.sonar/report-task.txt
Outdated
| @@ -0,0 +1,5 @@ | |||
| projectKey=bip4cast | |||
There was a problem hiding this comment.
.sonar directory should be ignored from versioning, for same reasons we removed .idea and binaries.
alefq
approved these changes
May 30, 2017
alefq
approved these changes
May 30, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Se solucionaron issues, archivo de configuracion para el analisis de sonar y actualizado el .gitignore para los archivos .idea y .apk