Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(phone) Upgrade UA phone provider #2016

Merged
merged 8 commits into from
Apr 12, 2024
Merged

feat(phone) Upgrade UA phone provider #2016

merged 8 commits into from
Apr 12, 2024

Conversation

lozik4
Copy link
Contributor

@lozik4 lozik4 commented Mar 30, 2024

Fix MSISDN format
Add real country codes

fcurella
fcurella requested changes Apr 5, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Could you rebase against the current master branch?

@lozik4
Copy link
Contributor Author

lozik4 commented Apr 5, 2024

@fcurella I did it, but some test in another
tests/providers/test_phone_number.py::TestSkSk::test_phone_number FAILED

fcurella
fcurella approved these changes Apr 9, 2024
View reviewed changes
Copy link
Collaborator

@fcurella fcurella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@fcurella fcurella merged commit 11055a7 into joke2k:master Apr 12, 2024
28 checks passed
@data-sync-user data-sync-user mentioned this pull request Jun 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fcurella fcurella fcurella approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lozik4 @fcurella