Test Suite Housekeeping (Part 3) #1167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcurella
requested changes
Apr 28, 2020
|
@fcurella I think travis hanged since the last merge to master. Anyway, looks like I might be rebasing my PR a fair amount prior to getting this merged if I do not split this now, so I will probably wrap this part up soon and continue with a new PR. |
malefice
changed the title
|
@fcurella I am done for this portion which (I estimate) accounts for 1/3 of the transition. The tests for other providers are a bit tedious/repetitive/lacking, so I am going to think about how to tackle them, and I also do not want to introduce too much |
|
@malefice It looks great! Impressive work! |
IlfirinPL
pushed a commit
to IlfirinPL/faker
that referenced
this pull request
Apr 9, 2021
* Add test fixtures exclusive for tests.providers * Pytestify tests.sphinx * Pytestify and improve user agent provider tests * Pytestify barcode provider tests * Fix flake8 bare except issue * Pytestify, reorganize, and improve Generator class tests * Pytestify, reorganize, and improve Faker class tests * Fix test failure * Pytestify currency provider tests * Pytestify isbn provider tests * Pytestify, reorganize, and improve internet provider tests * Pytestify, reorganize, and improve base provider tests * Fix CI errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I estimate that only 1/3 of the transition is complete.
What does this change
Since
Fakeralso now ships its ownpytestplugin, this PR aims to (fully or partially) transition the test suite from usingunitteststyle test topyteststyle tests as well as to start usingFaker's own fixtures in the test suite. This can also serve as a good opportunity to review the quality of individual tests, and improvements will be made whenever possible.