Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for empty var with None default value #332

Merged
merged 2 commits into from
Oct 6, 2021
Merged

Add support for empty var with None default value #332

merged 2 commits into from
Oct 6, 2021

Conversation

mehdy
Copy link
Contributor

@mehdy mehdy commented Oct 5, 2021

Closes #209

@mehdy
Copy link
Contributor Author

mehdy commented Oct 5, 2021

@sergeyklay ready for review.

@sergeyklay
Copy link
Collaborator

@mehdy Could you please update change log?

@sergeyklay sergeyklay self-requested a review October 6, 2021 08:19
@sergeyklay sergeyklay self-assigned this Oct 6, 2021
@sergeyklay sergeyklay added the enhancement New feature or request label Oct 6, 2021
@coveralls
Copy link

coveralls commented Oct 6, 2021 •
edited
Loading

Coverage Status

Coverage increased (+0.02%) to 90.927% when pulling 26fb010 on mehdy:default-none into 972b103 on joke2k:develop.

@sergeyklay sergeyklay added hacktoberfest hacktoberfest-accepted See https://hacktoberfest.digitalocean.com/ for participants details and removed hacktoberfest labels Oct 6, 2021
@sergeyklay sergeyklay changed the base branch from main to develop October 6, 2021 08:23
@sergeyklay
Copy link
Collaborator

@mehdy Please note, I changed the base branch from main to develop

@mehdy
Copy link
Contributor Author

mehdy commented Oct 6, 2021

@mehdy Could you please update change log?

Sure!

@mehdy mehdy force-pushed the default-none branch 3 times, most recently from a3af229 to 7cb24d7 Compare October 6, 2021 10:31
@mehdy
Copy link
Contributor Author

mehdy commented Oct 6, 2021

Done!

sergeyklay
sergeyklay reviewed Oct 6, 2021
View reviewed changes
CHANGELOG.rst Outdated Show resolved Hide resolved
sergeyklay
sergeyklay approved these changes Oct 6, 2021
View reviewed changes
Copy link
Collaborator

@sergeyklay sergeyklay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you!

@mehdy
Add update to CHANGELOG.rst
26fb010 
Signed-off-by: Mehdy Khoshnoody <[email protected]>
@sergeyklay sergeyklay merged commit 7dc1c1b into joke2k:develop Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees

@sergeyklay sergeyklay

Labels
enhancement New feature or request hacktoberfest-accepted See https://hacktoberfest.digitalocean.com/ for participants details
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for SOME_VAR=(int, None)?
3 participants
@mehdy @sergeyklay @coveralls