-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take minimum_makers config var value into account on Send page #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice change! Yeah I'd say we can live with the 99 being hardcoded for now. 👍
ghost
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! ✅
ghost
deleted the
minimum-makers-on-send-page
branch
February 22, 2022 12:20
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #101
This PR fetches the
minimum_makers
config variable and uses it as minimum amount of collaborators on the Send page.This means a taker operation cannot be started with a lower value than what is specified in the config file.
One little caveat is that the initial value for the amount collaborators is randomized between
[5, 7]
(min +1, min +3), which can lead to the initial value not being shown as active button in theCollaboratorsSelector
component.Is this acceptable for now? What do you think?
Screenshot for
minimum_makers := 2
:Also, the approach of parsing an error message from
text/html
is removed as this has been fixed in joinmarket-clientserver#1170Edit: this also does not take into account if the value is greater than
99
- which is the default maximum amount. Guess that is an unreasonable value and can therefore be ignored.